Repository navigation
Conversation
gnodet
reviewed
Jul 16, 2025
| import java.nio.Buffer; | ||
| import java.nio.ByteBuffer; | ||
| import java.nio.ByteOrder; | ||
| import java.text.ParseException; |
There was a problem hiding this comment.
ParseException does not make much sense here imho.
There's a VisitClassException defined in the package, should we use it ?
Contributor
Author
There was a problem hiding this comment.
Maybe, if we're assuming this is only used from a visitor. Currently that's true. I'm not sure it fits semantically though.
The other possibility is to define a new UnrecognizedConstantType exception.
elharo
marked this pull request as ready for review
July 16, 2025 11:00
gnodet
approved these changes
Jul 16, 2025
|
@elharo The PR can't be associated to a milestone, because there are multiple open milestones. Please add the text "branch: master" to the description to the milestone where this PR belongs to. |
|
@elharo Please assign appropriate label to PR according to the type of change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously this would result in a raw runtime exception nothing was catching.
fixes #145