Xhtml5BaseSink may emit invalid attributes for Sink.inline() when passing multiple attributes #1034

Activity

1. kwin

   added

   bugSomething isn't workingSomething isn't working

   on Feb 16, 2026
2. kwin commented on Feb 16, 2026

   

   kwin

   on Feb 16, 2026

   Last edited by kwin

   MemberAuthor

   More actions

   The culprit is

   maven-doxia/doxia-core/src/main/java/org/apache/maven/doxia/sink/impl/Xhtml5BaseSink.java

   Line 1252 in e5c77a1

   writeStartTag(tag, attributesNoSemantics);

   which just emits all non Semantic attributes as is. IMHO the ones not valid as HTML5 attributes from

   maven-doxia/doxia-core/src/main/java/org/apache/maven/doxia/sink/impl/SinkEventAttributeSet.java

   Lines 92 to 106 in e5c77a1

   	static {
   	UNDERLINE = new SinkEventAttributeSet(DECORATION, "underline").unmodifiable();
   	OVERLINE = new SinkEventAttributeSet(DECORATION, "overline").unmodifiable();
   	LINETHROUGH = new SinkEventAttributeSet(DECORATION, "line-through").unmodifiable();
   	SOURCE = new SinkEventAttributeSet(DECORATION, "source").unmodifiable();
   	BOLD = new SinkEventAttributeSet(STYLE, "bold").unmodifiable();
   	ITALIC = new SinkEventAttributeSet(STYLE, "italic").unmodifiable();
   	MONOSPACED = new SinkEventAttributeSet(STYLE, "monospaced").unmodifiable();
   	LEFT = new SinkEventAttributeSet(ALIGN, "left").unmodifiable();
   	RIGHT = new SinkEventAttributeSet(ALIGN, "right").unmodifiable();
   	CENTER = new SinkEventAttributeSet(ALIGN, "center").unmodifiable();
   	JUSTIFY = new SinkEventAttributeSet(ALIGN, "justify").unmodifiable();
   	}

   should be converted to supported semantic attributes or supported inline elements first.

   @michael-o WDYT?
3. kwin

   added 6 commits that reference this issue on Feb 16, 2026

   Add (failing) test case for multiple inline attributes

   ...

   cd51872

   Convert non-HTML5 compliant inline attributes to compliant ones

   ...

   1546c8b

   Convert non-HTML5-compliant inline attributes to compliant ones

   ...

   124748c

   Convert non-HTML5-compliant inline attributes to compliant ones

   ...

   4a8d62c

   Convert non-HTML5-compliant inline attributes to compliant ones

   ...

   5021095

   Convert non-HTML5-compliant inline attributes to compliant ones

   ...

   0e29965
4. kwin

   closed this as completedin 5722f35on Feb 24, 2026
5. slawekjaranowski

   added a commit that references this issue on Mar 19, 2026

   Convert non-HTML5-compliant inline attributes to compliant ones

   ...

   This issue will close once commit 5722f35 is merged into the 'master' branch.

   5722f35