Skip to content

[DOXIA-760] Clarify default table cell alignment #875

Closed

Description

@jira-importer

Konrad Windszus opened DOXIA-760 and commented

Compare with the discussion at https://issues.apache.org/jira/browse/MSKINS-230?page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel&focusedCommentId=17897626#comment-17897626.

For markdown one needs to leverage

:---

for left alignment (https://github.github.com/gfm/#tables-extension-) instead of

—

in the delimiter row. The latter must only be used for default alignment.


Issue Links:

  • MSKINS-230 Text in <th>/<td> ignore default alignment

Remote Links:

Activity

  1. jira-importer commented on Nov 12, 2024

    @jira-importer
    Author

    Konrad Windszus commented

    Michael Osipov How can one now indicate for a two column table a default (whatever that is) alignment for the first column, but aligning the second one centrally with Sink.tableRows(...) The only constants defined for the first argument array items is

    1. https://maven.apache.org/doxia/doxia/doxia-sink-api/apidocs/org/apache/maven/doxia/sink/Sink.html#JUSTIFY_LEFT
    2. https://maven.apache.org/doxia/doxia/doxia-sink-api/apidocs/org/apache/maven/doxia/sink/Sink.html#JUSTIFY_CENTER
    3. https://maven.apache.org/doxia/doxia/doxia-sink-api/apidocs/org/apache/maven/doxia/sink/Sink.html#JUSTIFY_RIGHT

    Should we introduce a 4th choice named JUSTIFY_DEFAULT being -1?

  2. jira-importer commented on Nov 12, 2024

    @jira-importer
    Author

    Konrad Windszus commented

    APT does not even have a notion for default alignment of tables: https://maven.apache.org/doxia/references/apt-format.html#table

  3. jira-importer commented on Nov 13, 2024

    @jira-importer
    Author

    Michael Osipov commented

    We should first change Doxia Sink API...

  4. jira-importer commented on Nov 13, 2024

    @jira-importer
    Author

    Konrad Windszus commented

    I drafted something in #248. Please have a look.

  5. jira-importer commented on Nov 21, 2024

    @jira-importer
    Author

    Konrad Windszus commented

    Fixed in c36b516.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

bugSomething isn't workingpriority:majorMajor loss of function

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions