[tanvir-ux]

SinkEventAttributeSet.equals() already delegates to isEqual(), which compares only own attributes. hashCode() was adding the resolve parent, so two equal sets could have different hash codes.

I dropped the parent from hashCode() so it matches existing equality. getAttribute() still walks the parent. This is the least disruptive option from #1075. I did not change equals semantics.

checkHashCode now expects setResolveParent not to change the hash. I also added a contract test for two sets with the same own attributes and different parents.

This is independent of #1073 (the class move). Happy to rebase if that lands first.

Fixes #1075

Following this checklist to help us incorporate your
contribution quickly and easily:

• Your pull request should address just one issue, without pulling in other changes.
• Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
• Each commit in the pull request should have a meaningful subject line and body.
  Note that commits might be squashed by a maintainer on merge.
• Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied.
  This may not always be possible but is a best-practice.
• Run mvn verify to make sure basic checks pass.
  A more thorough check will be performed on your pull request automatically.
• You have run the integration tests successfully (mvn -Prun-its verify).

I ran mvn -pl doxia-core -am test -Dtest=SinkEventAttributeSetTest -Dsurefire.failIfNoSpecifiedTests=false locally (18 tests, green, including checkstyle/spotless/rat on those modules). I did not run -Prun-its.

• I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004
• In any other case, please file an Apache Individual Contributor License Agreement.

[slachiewicz]

#1073 landed as e83c5a2 and moved both files this PR touches, so it now conflicts.

The code is unchanged, only relocated:

• doxia-sink-api/src/main/java/org/apache/maven/doxia/sink/SinkEventAttributeSet.java —
  hashCode() is at line 358, still adding parentHash
• doxia-sink-api/src/test/java/org/apache/maven/doxia/sink/SinkEventAttributeSetTest.java

doxia-core keeps a deprecated subclass that declares neither equals nor hashCode, so
the fix still applies once, in the new location. SinkEventAttributeSetCompatibilityTest
in doxia-core pins unrelated behaviour and needs no change.

The move was in flight when you opened this — apologies for the churn.

This comment was created with AI assistance.

[tanvir-ux]

Rebased onto master after #1073. Same hashCode change, now in doxia-sink-api.