Repository navigation
Deprecate LineBreaker and take commons-io off the compile classpath - #1096
Merged
Merged
Conversation
Nothing in Doxia or the Maven repositories calls it, and its write loop swallows every exception, so a failing writer would truncate output silently. Deprecated rather than deleted because the class is public API of a released module.
The seven IOUtils call sites become plain copy loops; the Java 8 baseline rules out Reader.transferTo and InputStream.readAllBytes. commons-io drops to test scope in four modules and off the compile classpath of all six.
slachiewicz
added
deprecated
slachiewicz
marked this pull request as ready for review
September 3, 2026 22:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1093. Two independent commits:
LineBreakeris deprecated for removal in 2.3.0 rather than deleted, since it is public API of a released module; the sevenIOUtilscall sites become copy loops, which moves commons-io to test scope in doxia-core, fml, markdown and xdoc and off apt and xhtml5 entirely.Verified:
mvn install→ BUILD SUCCESS, all module test suites green, japicmp clean on doxia-sink-api and doxia-core.This change was created with AI assistance.