Skip to content

[DOXIA-737] [REGRESSION] Making EmitAnchorsForIndexableEntries by def… - #214

Merged
asfgit merged 1 commit into
masterfrom
DOXIA-737
May 17, 2024
Merged

asfgit merged 1 commit into
masterfrom
DOXIA-737

Conversation

@michael-o

Copy link
Copy Markdown
Member

…ault does not extract document titles anymore

This closes #214

@michael-o
michael-o requested a review from kwin May 16, 2024 21:04
…ault does not extract document titles anymore

This closes #214

@kwin kwin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this. Wondering though why there is no IT/UT having caught that. Probably time to add one…

@kwin

kwin commented May 17, 2024

Copy link
Copy Markdown
Member

BTW: There is no need for git commit messages which close the PR.. This is only useful when referencing a GitHub issue.

@michael-o

Copy link
Copy Markdown
Member Author

BTW: There is no need for git commit messages which close the PR.. This is only useful when referencing a GitHub issue.

I know, I do it on purpose to establish the connection between the commit and the PR when browsing git log from the terminal. Metadata.

@michael-o

Copy link
Copy Markdown
Member Author

Thanks for fixing this. Wondering though why there is no IT/UT having caught that. Probably time to add one…

Do you have an idea from the top of your head? Took me some time to tackle this. Don't whether it should be in Doxia or somewhere later this test.

@kwin

kwin commented May 17, 2024

Copy link
Copy Markdown
Member

The test should be in Doxia. But I won’t have time to look into this the next two weeks. Should not block merging though

@michael-o

Copy link
Copy Markdown
Member Author

The test should be in Doxia. But I won’t have time to look into this the next two weeks. Should not block merging though

Thanks, I will go on otherwise it would block the entire release train. I have one more improvement for Doxia Sitetools left.

@asfgit asfgit closed this in c35e61c May 17, 2024
@asfgit
asfgit merged commit c35e61c into master May 17, 2024
@michael-o
michael-o deleted the DOXIA-737 branch May 17, 2024 19:47
@jira-importer

Copy link
Copy Markdown

Resolve #864

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants