Repository navigation
[MENFORCER-430] Allow one of many files in RequireFiles rules to pass - #183
Merged
Merged
Conversation
Member
|
@raupachz thanks for PR - looks ok. Please add corresponding documentation in this PR - we will have complete change. |
slawekjaranowski
self-requested a review
September 6, 2022 07:05
Contributor
Author
|
@slawekjaranowski Thank you for reviewing. PR is updated. |
Member
|
@raupachz thanks |
|
Resolve #547 |
1 similar comment
|
Resolve #547 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves the issue MENFORCER-430.
Given a list of files it was not possible to enforce only a list where only one filed would be sufficient.
For example check if one of the following files exists:
A new paramenter
satisfyAnywas added toAbstractRequiresFiles. IfsatisfyAnyistruethen it is enough if one of the files passes the check.This PR affects the following built-in rules:
Tests have been added.
I do not know if the documentation of the builtin-rules updates itself with the new paramenter
satisfyAnyor if I have to do this myself.Please note this is an
up-for-grabsissue and given my lack of experience in Maven Development I might have missed something.Following this checklist to help us incorporate your
contribution quickly and easily:
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
[MENFORCER-XXX] - Fixes bug in ApproximateQuantiles,where you replace
MENFORCER-XXXwith the appropriate JIRA issue. Best practiceis to use the JIRA issue title in the pull request title and in the first line of the
commit message.
mvn clean verifyto make sure basic checks pass. A more thorough check willbe performed on your pull request automatically.
mvn -Prun-its clean verify).If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.
I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004
In any other case, please file an Apache Individual Contributor License Agreement.