Skip to content

[MENFORCER-425] Clarify usage of maven-enforcer-rules - #215

Merged
kwin merged 1 commit into
masterfrom
kwin-patch-1
Jan 1, 2023
Merged

kwin merged 1 commit into
masterfrom
kwin-patch-1

Conversation

@kwin

@kwin kwin commented Jan 1, 2023

Copy link
Copy Markdown
Member

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Make sure there is a JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without
    pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [MENFORCER-XXX] - Fixes bug in ApproximateQuantiles,
    where you replace MENFORCER-XXX with the appropriate JIRA issue. Best practice
    is to use the JIRA issue title in the pull request title and in the first line of the
    commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean verify to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.
  • You have run the integration tests successfully (mvn -Prun-its clean verify).

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

@kwin
kwin requested a review from slawekjaranowski January 1, 2023 10:30
@kwin
kwin merged commit edfd5b1 into master Jan 1, 2023
@kwin
kwin deleted the kwin-patch-1 branch January 1, 2023 11:47
@slawekjaranowski slawekjaranowski added the documentation Improvements or additions to documentation label Jan 4, 2023
@jira-importer

Copy link
Copy Markdown

Resolve #544

1 similar comment
@jira-importer

Copy link
Copy Markdown

Resolve #544

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants