Repository navigation
[MENFORCER-455] New Enforcer API - #216
Conversation
|
TODO:
|
|
|
||
| private final ComponentConfigurator componentConfigurator; | ||
|
|
||
| private final PlexusContainer plexusContainer; |
There was a problem hiding this comment.
Hm, this is really legacy. New code should no longer rely on that but rather on https://www.eclipse.org/sisu/docs/api/org.eclipse.sisu.inject/reference/org/eclipse/sisu/inject/BeanLocator.html for dynamic lookup
There was a problem hiding this comment.
We shouldn't support custom rules with legacy plexus annotations at all but only ones leveraging JSR 330 annotations.
There was a problem hiding this comment.
So which Maven component should we use for lookup only JSR 330?
There was a problem hiding this comment.
Even in new Api we use PlexusContainer
So now I don't see another way.
8784339 to
0b2040c
Compare
0b2040c to
7e12510
Compare
|
@kwin Do you accept my responses? Anybody else has any more remarks? |
- New API based on JSR 330 components
7e12510 to
bf5824b
Compare
|
Resolve #822 |
1 similar comment
|
Resolve #822 |
Following this checklist to help us incorporate your
contribution quickly and easily:
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
[MENFORCER-XXX] - Fixes bug in ApproximateQuantiles,where you replace
MENFORCER-XXXwith the appropriate JIRA issue. Best practiceis to use the JIRA issue title in the pull request title and in the first line of the
commit message.
mvn clean verifyto make sure basic checks pass. A more thorough check willbe performed on your pull request automatically.
mvn -Prun-its clean verify).If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.
I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004
In any other case, please file an Apache Individual Contributor License Agreement.