Skip to content

[MENFORCER-455] New Enforcer API - #216

Merged
slawekjaranowski merged 1 commit into
masterfrom
MENFORCER-455
Jan 4, 2023
Merged

slawekjaranowski merged 1 commit into
masterfrom
MENFORCER-455

Conversation

@slawekjaranowski

Copy link
Copy Markdown
Member
  • New API based on JSR 330 components

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Make sure there is a JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without
    pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [MENFORCER-XXX] - Fixes bug in ApproximateQuantiles,
    where you replace MENFORCER-XXX with the appropriate JIRA issue. Best practice
    is to use the JIRA issue title in the pull request title and in the first line of the
    commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean verify to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.
  • You have run the integration tests successfully (mvn -Prun-its clean verify).

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

@slawekjaranowski

slawekjaranowski commented Jan 1, 2023 •

Copy link
Copy Markdown
Member Author

TODO:

  • documentation for new API
  • move Built-In Rules to new API - can be done in separate PR

@slawekjaranowski
slawekjaranowski marked this pull request as draft January 1, 2023 16:23
@slawekjaranowski
slawekjaranowski requested a review from kwin January 1, 2023 16:23

private final ComponentConfigurator componentConfigurator;

private final PlexusContainer plexusContainer;

@kwin kwin Jan 1, 2023 •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, this is really legacy. New code should no longer rely on that but rather on https://www.eclipse.org/sisu/docs/api/org.eclipse.sisu.inject/reference/org/eclipse/sisu/inject/BeanLocator.html for dynamic lookup

@kwin kwin Jan 1, 2023 •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We shouldn't support custom rules with legacy plexus annotations at all but only ones leveraging JSR 330 annotations.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So which Maven component should we use for lookup only JSR 330?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@slawekjaranowski slawekjaranowski added the enhancement New feature or request label Jan 2, 2023
@slawekjaranowski
slawekjaranowski marked this pull request as ready for review January 2, 2023 16:19
@slawekjaranowski
slawekjaranowski requested a review from kwin January 3, 2023 19:19
@slawekjaranowski

Copy link
Copy Markdown
Member Author

@kwin Do you accept my responses?
Can I do anything more with this PR?

Anybody else has any more remarks?
I would like to merge and go forward.

@kwin kwin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

- New API based on JSR 330 components
@slawekjaranowski
slawekjaranowski merged commit ec44333 into master Jan 4, 2023
@slawekjaranowski
slawekjaranowski deleted the MENFORCER-455 branch January 4, 2023 23:01
@jira-importer

Copy link
Copy Markdown

Resolve #822

1 similar comment
@jira-importer

Copy link
Copy Markdown

Resolve #822

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants