Skip to content

[MENFORCER-466] Changed the default set of dependency exclusions to exclude provided - #248

Merged
slawekjaranowski merged 1 commit into
apache:masterfrom
andrzejj0:MENFORCER-466-exclude-provided
Feb 21, 2023
Merged

slawekjaranowski merged 1 commit into
apache:masterfrom
andrzejj0:MENFORCER-466-exclude-provided

Conversation

@andrzejj0

@andrzejj0 andrzejj0 commented Feb 4, 2023 •

Copy link
Copy Markdown
Contributor

Following a regression indicated in https://issues.apache.org/jira/browse/MENFORCER-466, scope should exclude provided.

In this PR, if no other dependency exclusions are set, I'm applying the default dependency exclusions as are present in MavenRepositorySystemUtils.newSession(),

namely:

new AndDependencySelector( new ScopeDependencySelector( "test", "provided" ),
         new OptionalDependencySelector(), new ExclusionDependencySelector() );

@slawekjaranowski please review

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Make sure there is a JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without
    pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [MENFORCER-XXX] - Fixes bug in ApproximateQuantiles,
    where you replace MENFORCER-XXX with the appropriate JIRA issue. Best practice
    is to use the JIRA issue title in the pull request title and in the first line of the
    commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean verify to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.
  • You have run the integration tests successfully (mvn -Prun-its clean verify).

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

@andrzejj0
andrzejj0 force-pushed the MENFORCER-466-exclude-provided branch from 5d77a09 to d9ab2a4 Compare February 4, 2023 22:02
…xclude the provided and test scopes and to exclude optional dependencies
@andrzejj0
andrzejj0 force-pushed the MENFORCER-466-exclude-provided branch from d9ab2a4 to c349cce Compare February 4, 2023 22:17
@slawekjaranowski
slawekjaranowski merged commit 27c816d into apache:master Feb 21, 2023
@slawekjaranowski slawekjaranowski added the bug Something isn't working label Mar 14, 2023
@jira-importer

Copy link
Copy Markdown

Resolve #828

1 similar comment
@jira-importer

Copy link
Copy Markdown

Resolve #828

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants