Skip to content

[MPLUGIN-376] Drop legacy dependencies - #42

Merged
cstamas merged 6 commits into
masterfrom
drop-legacy
Oct 21, 2021
Merged

cstamas merged 6 commits into
masterfrom
drop-legacy

Conversation

@cstamas

@cstamas cstamas commented Oct 14, 2021 •

Copy link
Copy Markdown
Member

Plugin used a lot of legacy code, misused Mojo test case
and used old Junit 3.x TestCase, and missed some
dependencies (junit mostly).

Changes:

  • drop use of Junit 3 TestCase, use Junit4 everywhere
  • fix misuses of AbstractMojoTestCase when it is NOT mojo being tested
  • add missing junit test dep where missing
  • drop legacy p-c-d, sisu using exclusions/replacements
  • align JavaMojoDescriptorExtractorTest.java for semantic difference: current Shim returns empty list instead of null when no components (for null safety). Assers updated but semantic is same: "there are no components discovered".

Project cleaned up locally with help of apache/maven-parent#33
(locally modified parent and bashed POMs as long there were enforcer failures).


This PR continues work done in #37 and will be merged AFTER IT.

Plugin used a lot of legacy code, misused Mojo test case
and used old Junit 3.x TestCase, and missed some
dependencies (junit mostly).
@gnodet

gnodet commented Oct 14, 2021

Copy link
Copy Markdown
Contributor

I wonder if we should switch to junit 5 rather than going to junit 4. It has been out for 4 years now. I've done such a migration a few times, so I can work on it when those PRs are merged.

@cstamas

cstamas commented Oct 14, 2021

Copy link
Copy Markdown
Member Author

I am for it, but for now at least this PR aligns tests in this project, does not mix junit3 and junit4 anymore...

@cstamas cstamas changed the title Drop legacy [MPLUGIN-376] Drop legacy dependencies Oct 14, 2021
@cstamas cstamas self-assigned this Oct 15, 2021
@cstamas
cstamas merged commit d57eaff into master Oct 21, 2021
@cstamas
cstamas deleted the drop-legacy branch October 21, 2021 17:18
@jira-importer

Copy link
Copy Markdown

Resolve #693

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants