[elharo]

Fixes #1994

IpcNamedLock.tryUnlock() was silently discarding all exceptions from client.unlock() during timeout cleanup, masking real IO/connectivity issues.

Fix: log the failure at WARN level instead of swallowing it. The exception is still not propagated, preserving the best-effort cleanup semantics that must not crash the calling thread.

Test: added IpcNamedLockTest.unlockFailureDuringTimeoutCleanupIsLogged, which mocks IpcClient so that lock() times out and unlock() throws, then asserts the unlock failure is logged. The test fails against the old code (no log output) and passes with the fix.

[gnodet]

Clean, minimal fix that adds WARN-level logging for a previously silent exception catch in IpcNamedLock.tryUnlock(). The production change is correct — a single logger.warn() call using the inherited SLF4J logger, with the exception passed for stack trace logging. WARN level is appropriate for a secondary failure during timeout cleanup.

Two minor style notes (non-blocking):

1. Test class visibility: IpcNamedLockTest is declared package-private while every other test class in the project uses public class. Consider adding public for consistency.

2. stderr capture pattern: The test captures System.err to verify slf4j-simple output. This is pragmatic given the project's test dependencies, but worth noting it's not thread-safe for parallel test execution and depends on slf4j-simple default configuration.

This review was generated by an AI agent and may contain inaccuracies. Please verify all suggestions before applying.

Claude Code on behalf of gnodet

[elharo]

https://github.com/apache/maven-resolver/blob/89f2bc1b284e0024c3a4121f55dd0f4709d35009/maven-resolver-impl/src/test/java/org/eclipse/aether/internal/impl/DefaultRepositorySystemReentrancyTest.java seems to have broken the CI and went in without a pull request. We really need to block this at the repo level.

[elharo]

The Verify failures are pre-existing on master, not caused by this change.

Master commit 89f2bc1 has the identical 18 failing Verify jobs (e.g. windows-latest jdk-21-zulu 4.0.0-rc-6 fails on the same lines). The failure is a test-compile error in the maven-resolver-impl module:

DefaultRepositorySystemReentrancyTest.java:[361,17] incompatible types: no instance(s) of type variable(s) T exist so that java.util.List<T> conforms to java.util.Map<java.lang.String,org.eclipse.aether.spi.validator.ValidatorFactory>

introduced by commit f164aa9 Enh: Allow validator factory to abstain (#2008).

This PR only modifies the maven-resolver-named-locks-ipc module (IpcNamedLock + a regression test). All 27 unit tests + ITs for that module pass locally (-Prun-its verify), and spotless:check is green.

[kwin]

Master has been fixed meanwhile. Can you rebase?

[github-actions]

@elharo Please assign appropriate label to PR according to the type of change.