Skip to content

[MSHADE-479] Demote logging of shaded files to debug #676

Closed

Description

@jira-importer

Elliotte Rusty Harold opened MSHADE-479 and commented

Output from a recent failing build where I was looking for a test failure:

[INFO] Including com.facebook.presto:presto-benchmark-driver:jar:0.289-SNAPSHOT in the shaded jar.
[INFO] Including com.facebook.presto.scribe:presto-scribe-client:jar:1.16 in the shaded jar.
[INFO] Including com.facebook.drift:drift-api:jar:1.38 in the shaded jar.
[INFO] Including com.facebook.airlift:concurrent:jar:0.209 in the shaded jar.
[INFO] Including com.facebook.airlift:configuration:jar:0.209 in the shaded jar.
[INFO] Including cglib:cglib-nodep:jar:3.2.5 in the shaded jar.
[INFO] Including com.facebook.airlift:stats:jar:0.209 in the shaded jar.
[INFO] Including org.hdrhistogram:HdrHistogram:jar:2.1.9 in the shaded jar.
[INFO] Including io.airlift:slice:jar:0.38 in the shaded jar.
[INFO] Including org.openjdk.jol:jol-core:jar:0.2 in the shaded jar.
[INFO] Including com.facebook.airlift:event:jar:0.209 in the shaded jar.
[INFO] Including com.facebook.airlift:node:jar:0.209 in the shaded jar.
[INFO] Including com.facebook.airlift:http-client:jar:0.209 in the shaded jar.
[INFO] Including ch.qos.logback:logback-core:jar:1.2.3 in the shaded jar.
[INFO] Including org.eclipse.jetty:jetty-client:jar:9.4.14.v20181114 in the shaded jar.
[INFO] Including org.eclipse.jetty:jetty-io:jar:9.4.14.v20181114 in the shaded jar.
[INFO] Including org.eclipse.jetty:jetty-util:jar:9.4.14.v20181114 in the shaded jar.
[INFO] Including org.eclipse.jetty:jetty-http:jar:9.4.14.v20181114 in the shaded jar.
[INFO] Including org.eclipse.jetty.http2:http2-client:jar:9.4.14.v20181114 in the shaded jar.
[INFO] Including org.eclipse.jetty.http2:http2-common:jar:9.4.14.v20181114 in the shaded jar.
[INFO] Including org.eclipse.jetty.http2:http2-hpack:jar:9.4.14.v20181114 in the shaded jar.
[INFO] Including org.eclipse.jetty:jetty-alpn-client:jar:9.4.14.v20181114 in the shaded jar.
[INFO] Including org.eclipse.jetty.http2:http2-http-client-transport:jar:9.4.14.v20181114 in the shaded jar.
[INFO] Including org.eclipse.jetty:jetty-alpn-java-client:jar:9.4.14.v20181114 in the shaded jar.
[INFO] Including com.facebook.airlift:http-utils:jar:0.209 in the shaded jar.
[INFO] Including com.facebook.airlift:trace-token:jar:0.209 in the shaded jar.
[INFO] Including net.jodah:failsafe:jar:2.0.1 in the shaded jar.
[INFO] Including com.facebook.airlift:discovery:jar:0.209 in the shaded jar.
[INFO] Including com.fasterxml.jackson.core:jackson-core:jar:2.11.0 in the shaded jar.
[INFO] Including com.facebook.airlift:json:jar:0.209 in the shaded jar.
[INFO] Including com.fasterxml.jackson.datatype:jackson-datatype-jdk8:jar:2.11.0 in the shaded jar.
[INFO] Including com.fasterxml.jackson.datatype:jackson-datatype-jsr310:jar:2.11.0 in the shaded jar.
[INFO] Including com.fasterxml.jackson.datatype:jackson-datatype-guava:jar:2.11.0 in the shaded jar.
[INFO] Including com.fasterxml.jackson.datatype:jackson-datatype-joda:jar:2.11.0 in the shaded jar.
[INFO] Including com.fasterxml.jackson.module:jackson-module-parameter-names:jar:2.11.0 in the shaded jar.
[INFO] Including com.fasterxml.jackson.dataformat:jackson-dataformat-smile:jar:2.11.0 in the shaded jar.
[INFO] Including com.facebook.airlift:log:jar:0.209 in the shaded jar.
[INFO] Including io.airlift:units:jar:1.3 in the shaded jar.
[INFO] Including org.weakref:jmxutils:jar:1.19 in the shaded jar.
[INFO] Including com.google.inject:guice:jar:4.2.2 in the shaded jar.
[INFO] Including aopalliance:aopalliance:jar:1.0 in the shaded jar.
[INFO] Including javax.inject:javax.inject:jar:1 in the shaded jar.
[INFO] Including javax.annotation:javax.annotation-api:jar:1.3.2 in the shaded jar.
[INFO] Including javax.validation:validation-api:jar:2.0.1.Final in the shaded jar.
[INFO] Including joda-time:joda-time:jar:2.12.7 in the shaded jar.
[INFO] Including com.fasterxml.jackson.core:jackson-annotations:jar:2.11.0 in the shaded jar.
[INFO] Including com.fasterxml.jackson.core:jackson-databind:jar:2.11.0 in the shaded jar.
[INFO] Including com.facebook.drift:drift-codec:jar:1.38 in the shaded jar.
[INFO] Including com.facebook.drift:drift-protocol:jar:1.38 in the shaded jar.
[INFO] Including io.airlift:parameternames:jar:1.3 in the shaded jar.
[INFO] Including com.facebook.airlift:bytecode:jar:1.3 in the shaded jar.
[INFO] Including org.ow2.asm:asm:jar:9.0 in the shaded jar.
[INFO] Including org.ow2.asm:asm-tree:jar:9.0 in the shaded jar.
[INFO] Including org.ow2.asm:asm-util:jar:9.0 in the shaded jar.
[INFO] Including org.ow2.asm:asm-analysis:jar:9.0 in the shaded jar.
[INFO] Including com.facebook.drift:drift-client:jar:1.38 in the shaded jar.
[INFO] Including com.facebook.drift:drift-transport-spi:jar:1.38 in the shaded jar.
[INFO] Including com.facebook.drift:drift-transport-netty:jar:1.38 in the shaded jar.
[INFO] Including com.facebook.airlift:security:jar:0.209 in the shaded jar.
[INFO] Including io.netty:netty-common:jar:4.1.107.Final in the shaded jar.
[INFO] Including io.netty:netty-buffer:jar:4.1.107.Final in the shaded jar.
[INFO] Including io.netty:netty-handler-proxy:jar:4.1.107.Final in the shaded jar.
[INFO] Including io.netty:netty-codec-socks:jar:4.1.107.Final in the shaded jar.
[INFO] Including io.netty:netty-codec-http:jar:4.1.107.Final in the shaded jar.
[INFO] Including io.netty:netty-handler:jar:4.1.107.Final in the shaded jar.
[INFO] Including io.netty:netty-resolver:jar:4.1.107.Final in the shaded jar.
[INFO] Including io.netty:netty-transport-native-unix-common:jar:4.1.107.Final in the shaded jar.
[INFO] Including io.netty:netty-transport-classes-epoll:jar:4.1.107.Final in the shaded jar.
[INFO] Including io.netty:netty-transport-native-epoll:jar:linux-x86_64:4.1.107.Final in the shaded jar.
[INFO] Including io.netty:netty-transport:jar:4.1.107.Final in the shaded jar.
[INFO] Including io.netty:netty-codec:jar:4.1.107.Final in the shaded jar.
[INFO] Including com.google.guava:guava:jar:26.0-jre in the shaded jar.
[INFO] Including com.google.code.findbugs:jsr305:jar:3.0.2 in the shaded jar.
[INFO] Including org.checkerframework:checker-qual:jar:2.5.2 in the shaded jar.
[INFO] Including com.google.errorprone:error_prone_annotations:jar:2.1.3 in the shaded jar.
[INFO] Including com.google.j2objc:j2objc-annotations:jar:1.1 in the shaded jar.
[INFO] Including org.codehaus.mojo:animal-sniffer-annotations:jar:1.14 in the shaded jar.
[INFO] Including org.apache.bval:bval-jsr:jar:2.0.0 in the shaded jar.

How much of that was relevant?

None.

This log output is rarely if ever helpful or needed. Get rid of it.


Remote Links:

Activity

  1. jira-importer commented on Jul 12, 2024

    @jira-importer
    Author

    Michael Osipov commented

    It shouldn't be deleted, but be at debug only

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions