Skip to content

ORC-1174: Add Ubuntu 22.04 to GitHub Action - #1121

Merged
williamhyun merged 3 commits into
apache:mainfrom
dongjoon-hyun:ubuntu22-2
May 19, 2022
Merged

williamhyun merged 3 commits into
apache:mainfrom
dongjoon-hyun:ubuntu22-2

Conversation

@dongjoon-hyun

@dongjoon-hyun dongjoon-hyun commented May 18, 2022 •

Copy link
Copy Markdown
Member

What changes were proposed in this pull request?

This PR aims to add Ubuntu 22.04 to GitHub Action.

Why are the changes needed?

This will help the verification on the latest release.

Although GitHub Action Virtual Environments don't support Ubuntu 22.04 officially yet, Ubuntu 22.04 is available as Public Beta.

How was this patch tested?

Pass the GitHub Action on this PR.

@dongjoon-hyun

dongjoon-hyun commented May 18, 2022 •

Copy link
Copy Markdown
Member Author

I didn't see this failure on my local Ubuntu 22.04.
I'm investigating rat failure in GitHub Action Ubuntu 22.04.
It seems the one which was reported last vote by Prasanth.

@dongjoon-hyun

Copy link
Copy Markdown
Member Author

Could you review this, @guiyanakuang and @williamhyun ?

@dongjoon-hyun dongjoon-hyun changed the title ORC-1174: Add Ubuntu 22.04 to GitHub Action ORC-1174: Add Ubuntu 22.04 to GitHub Action May 19, 2022
@dongjoon-hyun

Copy link
Copy Markdown
Member Author

Also, cc @prasanthj

@guiyanakuang

Copy link
Copy Markdown
Member

+1, LGTM from my side.

@williamhyun williamhyun left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM

@williamhyun
williamhyun merged commit 098b2fe into apache:main May 19, 2022
@dongjoon-hyun

Copy link
Copy Markdown
Member Author

Thank you, @guiyanakuang and @williamhyun !

@dongjoon-hyun
dongjoon-hyun deleted the ubuntu22-2 branch May 19, 2022 03:22
dongjoon-hyun added a commit that referenced this pull request May 19, 2022
### What changes were proposed in this pull request?

This PR aims to add `Ubuntu 22.04` to GitHub Action.

### Why are the changes needed?

This will help the verification on the latest release.

Although [GitHub Action Virtual Environments](https://github.com/actions/virtual-environments) don't support `Ubuntu 22.04` officially yet, `Ubuntu 22.04` is available as `Public Beta`.

- actions/runner-images#5490

### How was this patch tested?

Pass the GitHub Action on this PR.

(cherry picked from commit 098b2fe)
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
dongjoon-hyun added a commit to dongjoon-hyun/orc that referenced this pull request May 19, 2022
### What changes were proposed in this pull request?

This PR aims to add `Ubuntu 22.04` to GitHub Action.

### Why are the changes needed?

This will help the verification on the latest release.

Although [GitHub Action Virtual Environments](https://github.com/actions/virtual-environments) don't support `Ubuntu 22.04` officially yet, `Ubuntu 22.04` is available as `Public Beta`.

- actions/runner-images#5490

### How was this patch tested?

Pass the GitHub Action on this PR.

(cherry picked from commit 098b2fe)
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
(cherry picked from commit c1d5ca8)
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
@dongjoon-hyun dongjoon-hyun modified the milestones: 1.7.5, 1.8.0 May 19, 2022
@dongjoon-hyun

Copy link
Copy Markdown
Member Author

For branch-1.7, I made the following backporting PR.

cxzl25 pushed a commit to cxzl25/orc that referenced this pull request Jan 11, 2024
### What changes were proposed in this pull request?

This PR aims to add `Ubuntu 22.04` to GitHub Action.

### Why are the changes needed?

This will help the verification on the latest release.

Although [GitHub Action Virtual Environments](https://github.com/actions/virtual-environments) don't support `Ubuntu 22.04` officially yet, `Ubuntu 22.04` is available as `Public Beta`.

- actions/runner-images#5490

### How was this patch tested?

Pass the GitHub Action on this PR.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants