Repository navigation
Use duplicates when writing from ByteBuf pair to avoid multiple threads issues - #1203
Merged
Merged
Conversation
Contributor
Author
|
@jai1 @rdhabalia PTAL at this one |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This is a fix for #1201.
The truncation happens when, during an unload, the topic moves from one broker to another. If the write operation on the previous connection was still ongoing, it can cause issues when the new IO (associated with the "new" connection) will start writing on the new socket.
Modifications
Take a duplicate of the
ByteBufso that each thread will have its ownreaderIndexon the buffer.