Skip to content

[improve][test] PIP-467: Convert pulsar-broker test files logging from SLF4J to slog - #25536

Merged
merlimat merged 4 commits into
apache:masterfrom
merlimat:slog-broker-tests
Apr 16, 2026
Merged

merlimat merged 4 commits into
apache:masterfrom
merlimat:slog-broker-tests

Conversation

@merlimat

Copy link
Copy Markdown
Contributor

Summary

  • Convert 358 test files in the pulsar-broker module from SLF4J to slog structured logging
  • Apply the same conversion patterns used in the main sources PR ([improve] PIP-467: Convert pulsar-broker module logging from SLF4J to slogΒ #25535): structured .attr(...) calls, .exception(...) for throwables, and short form log.level("msg") when no attributes are present
  • Strip stale SLF4J {} placeholder text from log messages

Test plan

  • ./gradlew :pulsar-broker:compileTestJava passes
  • ./gradlew :pulsar-broker:checkstyleTest passes
  • CI passes

Motivation

PIP-467

Note

Please label this PR with area/test and ready-to-test

…J to slog

Convert test sources in pulsar-broker from SLF4J to slog structured
logging (358 files).
@nodece
nodece requested a review from Copilot April 16, 2026 03:34

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review this pull request because it exceeds the maximum number of files (300). Try reducing the number of changed files and requesting a review from Copilot again.

@nodece nodece left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review: attribute naming issues in SLF4J β†’ slog conversion. See inline comments for specific fixes.

Co-authored-by: Zixuan Liu <nodeces@gmail.com>
@merlimat
merlimat merged commit d135252 into apache:master Apr 16, 2026
42 checks passed
@merlimat
merlimat deleted the slog-broker-tests branch April 16, 2026 16:54
@lhotari lhotari added this to the 5.0.0-M1 milestone Jun 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants