Repository navigation
[improve][test] PIP-467: Convert pulsar-broker test files logging from SLF4J to slog - #25536
Merged
Merged
Conversation
β¦J to slog Convert test sources in pulsar-broker from SLF4J to slog structured logging (358 files).
nodece
reviewed
Apr 16, 2026
nodece
left a comment
Member
There was a problem hiding this comment.
Code review: attribute naming issues in SLF4J β slog conversion. See inline comments for specific fixes.
nodece
reviewed
Apr 16, 2026
nodece
reviewed
Apr 16, 2026
nodece
reviewed
Apr 16, 2026
nodece
reviewed
Apr 16, 2026
nodece
reviewed
Apr 16, 2026
nodece
reviewed
Apr 16, 2026
nodece
reviewed
Apr 16, 2026
nodece
reviewed
Apr 16, 2026
nodece
reviewed
Apr 16, 2026
nodece
reviewed
Apr 16, 2026
nodece
reviewed
Apr 16, 2026
Co-authored-by: Zixuan Liu <nodeces@gmail.com>
lhotari
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pulsar-brokermodule from SLF4J to slog structured logging.attr(...)calls,.exception(...)for throwables, and short formlog.level("msg")when no attributes are present{}placeholder text from log messagesTest plan
./gradlew :pulsar-broker:compileTestJavapasses./gradlew :pulsar-broker:checkstyleTestpassesMotivation
PIP-467
Note
Please label this PR with
area/testandready-to-test