Repository navigation
[improve][test] Upgrade TestNG to 7.12.0 - #25666
Merged
Merged
Conversation
dao-jun
approved these changes
May 4, 2026
poorbarcode
pushed a commit
to poorbarcode/pulsar
that referenced
this pull request
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This PR upgrades the TestNG dependency from
7.7.1to7.12.0.7.7.1was released in December 2022, so the project has been three years behind the latest TestNG. Pulsar continues to rely on TestNG for the entire test suite, so the testing framework should be kept reasonably up-to-date in order to pick up bug fixes, stability improvements (notably around parallel data providers / shared thread pools, retry handling, and listener invocation ordering), and to stay compatible with newer JDKs and tooling.Notable highlights from the releases between
7.7.1and7.12.0(release notes on https://github.com/testng-team/testng/releases):ITestResult.statusis set toFAILURE; per-classconfigfailurepolicy; multiple data-provider/retry fixes; SnakeYAML upgraded to 2.0.CompletableFuture-based concurrency;@Inheritedon@Listeners.assertEqualsDeep(Set, Set, ...)correctness fix; ignored-test-count fix; CLI option to exclude tests.#2765); shared thread pool fixes; refreshDataProviderparameters on retry whencacheDataForTestRetries=false; retry-infinite-loop fix (#3231); JDK 25 workflow.Modifications
testngingradle/libs.versions.tomlfrom7.7.1to7.12.0.Verifying this change
This change is a trivial dependency upgrade. Verified locally with:
./gradlew assembleβ BUILD SUCCESSFUL./gradlew testClasses(compile tests across all modules) β BUILD SUCCESSFUL./gradlew spotlessCheck checkstyleMain checkstyleTestβ BUILD SUCCESSFULExisting tests cover usage of TestNG; no production code changes are introduced.
Does this pull request potentially affect one of the following parts: