Skip to content

[cleanup] PIP-468: Remove deprecated registerConsumer overloads - #25712

Merged
merlimat merged 1 commit into
apache:masterfrom
merlimat:st-v5-remove-deprecated-register
May 8, 2026
Merged

merlimat merged 1 commit into
apache:masterfrom
merlimat:st-v5-remove-deprecated-register

Conversation

@merlimat

@merlimat merlimat commented May 7, 2026

Copy link
Copy Markdown
Contributor

Summary

ScalableTopicController and ScalableTopicService each carried a registerConsumer overload that defaulted ScalableConsumerType to STREAM "for backward compatibility". The only production caller (ServerCnx) already passes the explicit type, so the overloads served only stale test code and were leaving deprecation warnings on every broker test compile.

Removed both overloads. Updated their only callers β€” broker tests (ScalableTopicControllerTest, ScalableTopicServiceTest) β€” to pass ScalableConsumerType.STREAM explicitly. No production behavior change.

Test plan

  • pulsar-broker compile + checkstyle clean.
  • ScalableTopicControllerTest 31/31 pass.
  • ScalableTopicServiceTest 16/16 pass.
  • No more [deprecation] registerConsumer warnings in the broker test compile output.

ScalableTopicController and ScalableTopicService each carried a 4/5-arg
registerConsumer overload that defaulted ScalableConsumerType to STREAM
"for backward compatibility". The only production caller (ServerCnx)
already passes the explicit type, so the overloads served only stale
test code and were leaving deprecation warnings on every broker test
compile.

Removed both overloads. Updated their only callers β€” broker tests
(ScalableTopicControllerTest and ScalableTopicServiceTest) β€” to pass
ScalableConsumerType.STREAM explicitly. No production behavior change.
@merlimat merlimat changed the title PIP-468: Remove deprecated registerConsumer overloads [cleanup] PIP-468: Remove deprecated registerConsumer overloads May 7, 2026
@lhotari
lhotari self-requested a review May 8, 2026 16:55

@lhotari lhotari left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@merlimat
merlimat merged commit 6d42559 into apache:master May 8, 2026
81 of 84 checks passed
@lhotari lhotari added this to the 5.0.0-M1 milestone Jun 12, 2026
@merlimat
merlimat deleted the st-v5-remove-deprecated-register branch October 24, 2026 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants