Skip to content

[cleanup][broker] Clean up scalable topic type references in ServerCnx - #25920

Merged
merlimat merged 1 commit into
apache:masterfrom
3pacccccc:clean-up-code
Jun 3, 2026
Merged

merlimat merged 1 commit into
apache:masterfrom
3pacccccc:clean-up-code

Conversation

@3pacccccc

Copy link
Copy Markdown
Contributor

Motivation

ServerCnx handles several scalable topic commands and sessions, but the scalable topic related code used a mix of fully qualified class names and imported types. This made the code harder to scan and inconsistent with the
surrounding style.

Modifications

This PR cleans up scalable topic related type references in ServerCnx by:

  • Adding imports for scalable topic session classes and proto command/type classes.
  • Replacing fully qualified scalable topic class references with imported type names.
  • Replacing fully qualified ConcurrentHashMap usage with the existing imported type.

There is no behavior change.

Verifying this change

  • Make sure that the change passes the CI checks.

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

@void-ptr974 void-ptr974 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for cleaning this up.

@lhotari lhotari added this to the 5.0.0-M1 milestone Jun 3, 2026
@merlimat
merlimat merged commit b45aa4e into apache:master Jun 3, 2026
44 checks passed
@3pacccccc
3pacccccc deleted the clean-up-code branch June 4, 2026 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants