Repository navigation
Conversation
Codecov Reportโ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #1061 +/- ##
============================================
+ Coverage 53.26% 53.45% +0.18%
- Complexity 651 693 +42
============================================
Files 208 211 +3
Lines 14303 14070 -233
Branches 5845 5537 -308
============================================
- Hits 7619 7521 -98
+ Misses 6308 6167 -141
- Partials 376 382 +6
Flags with carried forward coverage won't be shown. Click here to find out more. โ View full report in Codecov by Sentry. ๐ New features to boost your workflow:
|
lizhimins
previously requested changes
Aug 13, 2025
qianye1001
reviewed
Aug 13, 2025
| private static final Logger log = LoggerFactory.getLogger(LoggingInterceptor.class); | ||
|
|
||
| private static final LoggingInterceptor INSTANCE = new LoggingInterceptor(); | ||
| private static String remoteAddr = ""; |
Contributor
There was a problem hiding this comment.
using static not support muti client instance
qianye1001
reviewed
Aug 13, 2025
| public class ConsumeTask implements Callable<ConsumeResult> { | ||
| private static final Logger log = LoggerFactory.getLogger(ConsumeTask.class); | ||
|
|
||
| private static final String MESSAGE_VIEW_CONTEXT = "messageView"; |
โฆ-interceptor-context
qianye1001
reviewed
Aug 28, 2025
| * Warning: please DO NOT modify the signature of this method, it is used by OpenTelemetry instrumentation. | ||
| */ | ||
| private void send0(SettableFuture<List<SendReceiptImpl>> future0, String topic, MessageType messageType, | ||
| protected void send0(SettableFuture<List<SendReceiptImpl>> future0, String topic, MessageType messageType, |
Contributor
There was a problem hiding this comment.
Warning: please DO NOT modify the signature of this method, it is used by OpenTelemetry instrumentation.
terrancesli
added a commit
to terrancesli/rocketmq-clients
that referenced
this pull request
May 15, 2026
โฆpache#1061) Co-authored-by: xiaoying.ly <xiaoying.ly@alibaba-inc.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which Issue(s) This PR Fixes
Fixes #1060
Brief Description
Added MessageInterceptorContext information to provide more comprehensive information to the MessageInterceptor, including the remote address, messages sent by the producer, messages received, message type, consumption exceptions, and more.