Repository navigation
[Golang] fix(log.go): improve log directory retrieval logic - #1220
Merged
Merged
Conversation
Fixed an issue where the user home directory could not be correctly retrieved in some cases. When `os.UserHomeDir()` fails, a safe fallback path to the `/tmp` directory is provided. Change-Id: I1d4f3835e5f84c15459cef2b5aa7a389c4d1ca44
RongtongJin
approved these changes
Apr 15, 2026
terrancesli
added a commit
to terrancesli/rocketmq-clients
that referenced
this pull request
May 15, 2026
Fixed an issue where the user home directory could not be correctly retrieved in some cases. When `os.UserHomeDir()` fails, a safe fallback path to the `/tmp` directory is provided. Change-Id: I1d4f3835e5f84c15459cef2b5aa7a389c4d1ca44
RockteMQ-AI
approved these changes
Aug 10, 2026
RockteMQ-AI
left a comment
There was a problem hiding this comment.
Summary
Fixes a real bug: os.Getenv("user.home") is not a valid way to get the home directory in Go β the env var is HOME on Linux and USERPROFILE on Windows. os.UserHomeDir() is the correct cross-platform API. The fallback to /tmp is a sensible safety net.
Verdict: LGTM β clean, correct fix.
Automated review by "github-manager-bot"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed an issue where the user home directory could not be correctly retrieved in some cases. When
os.UserHomeDir()fails, a safe fallback path to the/tmpdirectory is provided.