Repository navigation
[Golang] fix(client.go): fix bug where NotifyClientTermination was never called - #1221
Merged
RongtongJin merged 4 commits intoApr 15, 2026
Merged
Conversation
Fixed logic error in `notifyClientTermination` method. The previous implementation incorrectly checked `err != nil` instead of `endpoints != nil`, which prevented `NotifyClientTermination` from being called. Added proper error handling with detailed logging for each notification attempt. Change-Id: I05c41d18419d107877150f623d97eedc29dcd546
โฆ request Added resource group information to the client termination notification request, including namespace and consumer group name. Change-Id: I26d28ad6f8e6ddf46f49ad5c01c7c0aac40135c3
RongtongJin
previously approved these changes
Apr 15, 2026
โฆogic Optimized the logging strategy when errors occur during message reception, with special handling for cases where no new messages are found to avoid unnecessary error log output. Meanwhile, the detailed error logging mechanism for other exceptional cases is preserved. Change-Id: I4b0ef5d2c41fea0727ff6950cbf415b4f935e20b
Extracted `topic` and `group` variables from the `syncLiteSubscription` method and adjusted log output formats based on different action types, making the code more readable and logs more detailed. Change-Id: Iba358e912af41266d84680435c682a5e19f55711
f1amingo
force-pushed
the
fix_notify_client_termination
branch
from
April 15, 2026 09:41
51ef6d0 to
d753836
Compare
RongtongJin
approved these changes
Apr 15, 2026
terrancesli
added a commit
to terrancesli/rocketmq-clients
that referenced
this pull request
May 15, 2026
โฆver called (apache#1221) * fix(client.go): fix bug where NotifyClientTermination was never called Fixed logic error in `notifyClientTermination` method. The previous implementation incorrectly checked `err != nil` instead of `endpoints != nil`, which prevented `NotifyClientTermination` from being called. Added proper error handling with detailed logging for each notification attempt. Change-Id: I05c41d18419d107877150f623d97eedc29dcd546 * fix(client.go): add resource group to client termination notification request Added resource group information to the client termination notification request, including namespace and consumer group name. Change-Id: I26d28ad6f8e6ddf46f49ad5c01c7c0aac40135c3 * fix(process_queue.go): Improve message reception exception handling logic Optimized the logging strategy when errors occur during message reception, with special handling for cases where no new messages are found to avoid unnecessary error log output. Meanwhile, the detailed error logging mechanism for other exceptional cases is preserved. Change-Id: I4b0ef5d2c41fea0727ff6950cbf415b4f935e20b * refactor(lite_push_consumer.go): extract variables and optimize logging Extracted `topic` and `group` variables from the `syncLiteSubscription` method and adjusted log output formats based on different action types, making the code more readable and logs more detailed. Change-Id: Iba358e912af41266d84680435c682a5e19f55711
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed logic error in
notifyClientTerminationmethod. The previous implementation incorrectly checkederr != nilinstead ofendpoints != nil, which preventedNotifyClientTerminationfrom being called. Added proper error handling with detailed logging for each notification attempt.