Skip to content

[Golang] fix(client.go): handle sync settings error during startup - #1235

Merged
RongtongJin merged 1 commit into
apache:masterfrom
f1amingo:fix_go_start
Apr 29, 2026
Merged

RongtongJin merged 1 commit into
apache:masterfrom
f1amingo:fix_go_start

Conversation

@f1amingo

Copy link
Copy Markdown
Contributor

When the client is not yet initialized and settings synchronization fails, propagate the error to startUp() method so it can return immediately instead of blocking forever waiting for settings. Also added startUpError field to the client struct to store errors that occur during startup.

When the client is not yet initialized and settings synchronization fails,
propagate the error to startUp() method so it can return immediately instead
of blocking forever waiting for settings. Also added startUpError field to
the client struct to store errors that occur during startup.

Change-Id: I5c28c65922b81083ac20f70aec2d4091248572c2

@guyinyou guyinyou left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@RongtongJin
RongtongJin merged commit 73c415b into apache:master Apr 29, 2026
14 of 15 checks passed
terrancesli added a commit to terrancesli/rocketmq-clients that referenced this pull request May 15, 2026
When the client is not yet initialized and settings synchronization fails,
propagate the error to startUp() method so it can return immediately instead
of blocking forever waiting for settings. Also added startUpError field to
the client struct to store errors that occur during startup.

Change-Id: I5c28c65922b81083ac20f70aec2d4091248572c2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants