Skip to content

[RIP-19]Pop consumer docs - #2862

Merged
duhenglucky merged 2 commits into
apache:pop_consumerfrom
hill007299:pop_consumer
May 12, 2021
Merged

duhenglucky merged 2 commits into
apache:pop_consumerfrom
hill007299:pop_consumer

Conversation

@hill007299

Copy link
Copy Markdown
Contributor

Make sure set the target branch to develop

What is the purpose of the change

XXXXX

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.1%) to 52.089% when pulling 9a7c61c on hill007299:pop_consumer into 0938aab on apache:pop_consumer.

@duhenglucky
duhenglucky merged commit 7d32c02 into apache:pop_consumer May 12, 2021
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

βœ… All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (pop_consumer@80bc36c). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff               @@
##             pop_consumer    #2862   +/-   ##
===============================================
  Coverage                ?   46.93%           
  Complexity              ?     3301           
===============================================
  Files                   ?      447           
  Lines                   ?    28773           
  Branches                ?     3909           
===============================================
  Hits                    ?    13505           
  Misses                  ?    13455           
  Partials                ?     1813           

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

πŸš€ New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants