Skip to content

[ISSUE #3503] fix the consumeOffset will be set as 0 when getMessage returns null - #3504

Merged
odbozhou merged 1 commit into
apache:5.0.0-betafrom
cserwen:bugfix_offset_0
Mar 18, 2022
Merged

odbozhou merged 1 commit into
apache:5.0.0-betafrom
cserwen:bugfix_offset_0

Conversation

@cserwen

@cserwen cserwen commented Nov 18, 2021

Copy link
Copy Markdown
Member

Make sure set the target branch to develop

What is the purpose of the change

#3503

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@cserwen cserwen changed the title [ISSUE ##3503 ] fix the consumeOffset will be set as 0 when getMessage returns null [ISSUE #3503] fix the consumeOffset will be set as 0 when getMessage returns null Nov 18, 2021
@coveralls

coveralls commented Nov 18, 2021 •

Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.2%) to 49.65% when pulling 7191932 on cserwen:bugfix_offset_0 into 56d2087 on apache:5.0.0-beta.

@cserwen

cserwen commented Jan 14, 2022

Copy link
Copy Markdown
Member Author

@odbozhou Can you help me to review this pr?

@duhenglucky duhenglucky added this to the 5.0.0-alpha milestone Jan 21, 2022
@lizhiboo

Copy link
Copy Markdown
Contributor

BTW, getMessageTmpResult == null contains two cases, such as defaultMessageStore is shutdown and defaultMessageStore is not readable. The detail causes of these two cases is lost. We can improve it in the future.

@cserwen

cserwen commented Feb 21, 2022

Copy link
Copy Markdown
Member Author

BTW, getMessageTmpResult == null contains two cases, such as defaultMessageStore is shutdown and defaultMessageStore is not readable. The detail causes of these two cases is lost. We can improve it in the future.

Yes! I agree with you.

@cserwen
cserwen changed the base branch from 5.0.0-alpha to 5.0.0-beta March 8, 2022 11:15
@cserwen

cserwen commented Mar 8, 2022

Copy link
Copy Markdown
Member Author

@duhenglucky Can you help me to review this pr?:blush:

@RongtongJin
RongtongJin deleted the branch apache:5.0.0-beta March 12, 2022 13:46
@cserwen

cserwen commented Mar 14, 2022

Copy link
Copy Markdown
Member Author

@RongtongJin Why this pr was closed?

@RongtongJin RongtongJin reopened this Mar 14, 2022
@RongtongJin

Copy link
Copy Markdown
Contributor

@RongtongJin Why this pr was closed?

Sorry, because the 5.0-alpha distribution has a rollback, I pushed a new 5.0-beta branch (deleted the original branch), resulting in the automatic close of PR.

@RongtongJin

Copy link
Copy Markdown
Contributor

@cserwen I reopen the pr

@cserwen

cserwen commented Mar 14, 2022

Copy link
Copy Markdown
Member Author

@RongtongJin Why this pr was closed?

Sorry, because the 5.0-alpha distribution has a rollback, I pushed a new 5.0-beta branch (deleted the original branch), resulting in the automatic close of PR.

OK, I got it.:smile:

@codecov-commenter

codecov-commenter commented Mar 14, 2022 •

Copy link
Copy Markdown

Codecov Report

❗ No coverage uploaded for pull request base (5.0.0-beta@4506f34). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             5.0.0-beta    #3504   +/-   ##
=============================================
  Coverage              ?   45.50%           
  Complexity            ?     5631           
=============================================
  Files                 ?      722           
  Lines                 ?    50616           
  Branches              ?     6935           
=============================================
  Hits                  ?    23034           
  Misses                ?    24621           
  Partials              ?     2961           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4506f34...7191932. Read the comment docs.

@odbozhou
odbozhou merged commit 0b7291b into apache:5.0.0-beta Mar 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants