Repository navigation
[ISSUE #3503] fix the consumeOffset will be set as 0 when getMessage returns null - #3504
Conversation
|
@odbozhou Can you help me to review this pr? |
|
BTW, getMessageTmpResult == null contains two cases, such as defaultMessageStore is shutdown and defaultMessageStore is not readable. The detail causes of these two cases is lost. We can improve it in the future. |
Yes! I agree with you. |
|
@duhenglucky Can you help me to review this pr?:blush: |
|
@RongtongJin Why this pr was closed? |
Sorry, because the 5.0-alpha distribution has a rollback, I pushed a new 5.0-beta branch (deleted the original branch), resulting in the automatic close of PR. |
|
@cserwen I reopen the pr |
OK, I got it.:smile: |
Codecov Report
@@ Coverage Diff @@
## 5.0.0-beta #3504 +/- ##
=============================================
Coverage ? 45.50%
Complexity ? 5631
=============================================
Files ? 722
Lines ? 50616
Branches ? 6935
=============================================
Hits ? 23034
Misses ? 24621
Partials ? 2961 Continue to review full report at Codecov.
|
Make sure set the target branch to
developWhat is the purpose of the change
#3503
Brief changelog
XX
Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice,
it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.[ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyleto make sure basic checks pass. Runmvn clean install -DskipITsto make sure unit-test pass. Runmvn clean test-compile failsafe:integration-testto make sure integration-test pass.