Skip to content

[ISSUE #3779] Add hook to execute after consume for pop - #3780

Merged
duhenglucky merged 1 commit into
apache:5.0.0-alphafrom
cserwen:pop-hook
Feb 14, 2022
Merged

duhenglucky merged 1 commit into
apache:5.0.0-alphafrom
cserwen:pop-hook

Conversation

@cserwen

@cserwen cserwen commented Jan 21, 2022

Copy link
Copy Markdown
Member

Make sure set the target branch to develop

What is the purpose of the change

#3779

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@coveralls

coveralls commented Jan 21, 2022 •

Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.004%) to 52.644% when pulling de0255d on cserwen:pop-hook into 631405e on apache:5.0.0-alpha.

@MatrixHB

Copy link
Copy Markdown
Contributor

@cserwen please pay attention to the CI build error.

@codecov-commenter

codecov-commenter commented Jan 25, 2022 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.
βœ… Project coverage is 46.49%. Comparing base (631405e) to head (de0255d).

Files with missing lines Patch % Lines
...consumer/ConsumeMessagePopConcurrentlyService.java 0.00% 3 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                @@
##             5.0.0-alpha    #3780      +/-   ##
=================================================
- Coverage          46.53%   46.49%   -0.05%     
+ Complexity          5333     5329       -4     
=================================================
  Files                641      641              
  Lines              44345    44348       +3     
  Branches            6116     6117       +1     
=================================================
- Hits               20637    20618      -19     
- Misses             20982    21005      +23     
+ Partials            2726     2725       -1     

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

πŸš€ New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

consumeMessageContext.getProps().put(MixAll.CONSUME_CONTEXT_TYPE, returnType.name());
}

if (ConsumeMessagePopConcurrentlyService.this.defaultMQPushConsumerImpl.hasHook()) {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The condition is the same to previous branch, it would be better to combine them.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@caigy OK, I will combine them.

@lizhiboo

lizhiboo commented Feb 9, 2022

Copy link
Copy Markdown
Contributor

@cserwen this pr contains many already merged prs, u can rebase to ur branch firstly.

@cserwen

cserwen commented Feb 11, 2022

Copy link
Copy Markdown
Member Author

@lizhiboo Ok, I will rebase it.

@duhenglucky
duhenglucky merged commit de76e06 into apache:5.0.0-alpha Feb 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants