Repository navigation
[ISSUE #3779] Add hook to execute after consume for pop - #3780
Merged
Merged
Conversation
Contributor
|
@cserwen please pay attention to the CI build error. |
Codecov Reportβ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 5.0.0-alpha #3780 +/- ##
=================================================
- Coverage 46.53% 46.49% -0.05%
+ Complexity 5333 5329 -4
=================================================
Files 641 641
Lines 44345 44348 +3
Branches 6116 6117 +1
=================================================
- Hits 20637 20618 -19
- Misses 20982 21005 +23
+ Partials 2726 2725 -1 β View full report in Codecov by Sentry. π New features to boost your workflow:
|
caigy
requested changes
Feb 7, 2022
| consumeMessageContext.getProps().put(MixAll.CONSUME_CONTEXT_TYPE, returnType.name()); | ||
| } | ||
|
|
||
| if (ConsumeMessagePopConcurrentlyService.this.defaultMQPushConsumerImpl.hasHook()) { |
Contributor
There was a problem hiding this comment.
The condition is the same to previous branch, it would be better to combine them.
RongtongJin
force-pushed
the
5.0.0-alpha
branch
from
February 8, 2022 02:42
5254805 to
0b4adb4
Compare
lizhiboo
approved these changes
Feb 9, 2022
Contributor
|
@cserwen this pr contains many already merged prs, u can rebase to ur branch firstly. |
Member
Author
|
@lizhiboo Ok, I will rebase it. |
yuz10
approved these changes
Feb 14, 2022
duhenglucky
approved these changes
Feb 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make sure set the target branch to
developWhat is the purpose of the change
#3779
Brief changelog
XX
Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice,
it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.[ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyleto make sure basic checks pass. Runmvn clean install -DskipITsto make sure unit-test pass. Runmvn clean test-compile failsafe:integration-testto make sure integration-test pass.