Skip to content

[ISSUE #3741] Use wait-until-${async-complete}-reaches DSL instead of sleep(n) to to reduce invalid wait time. - #3829

Merged
RongtongJin merged 125 commits into
apache:5.0.0-alphafrom
Erik1288:5.0.0-alpha-wait-until-dsl-unit-test
Feb 9, 2022
Merged

RongtongJin merged 125 commits into
apache:5.0.0-alphafrom
Erik1288:5.0.0-alpha-wait-until-dsl-unit-test

Conversation

@Erik1288

@Erik1288 Erik1288 commented Feb 9, 2022

Copy link
Copy Markdown
Contributor

Make sure set the target branch to develop

What is the purpose of the change

Reduce invalid wait time in unit-test.

Brief changelog

Use wait-until-${async-complete}-reaches DSL instead of sleep(n) to to reduce invalid wait time.

Verifying this change

pass ut.

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

dongeforever and others added 28 commits December 10, 2021 16:20
[RIP-26] Improve Batch Message Processing Throughput
Conflicts:
	tools/src/main/java/org/apache/rocketmq/tools/admin/DefaultMQAdminExt.java
	tools/src/main/java/org/apache/rocketmq/tools/admin/MQAdminExt.java
	tools/src/main/java/org/apache/rocketmq/tools/command/MQAdminStartup.java
Signed-off-by: zhangyang21 <zhangyang21@xiaomi.com>
Signed-off-by: zhangyang21 <zhangyang21@xiaomi.com>
Signed-off-by: zhangyang21 <zhangyang21@xiaomi.com>
* [Feature] Support topic attributes.

* [Feature] Topic attributes unit-test.
…tore. (#3712)

* [RIP-26] Both CQ and BCQ will be supported in DefaultMessageStore.

* [RIP-26] Both CQ and BCQ will be supported in DefaultMessageStore.
…ests issue. (#3713)

* [RIP-26] Both CQ and BCQ will be supported in DefaultMessageStore.

* [RIP-26] Both CQ and BCQ will be supported in DefaultMessageStore.

* Part of ISSUE #3708. Refactor CQ and BCQ loading process.

* Mock getDiskSpaceWarningLevelRatio and getDiskSpaceCleanForciblyRatio for ut.

* Optimize batch message unit-test.

* Mock getDiskSpaceWarningLevelRatio and getDiskSpaceCleanForciblyRatio for ut.

* Optimize batch message unit-test.
…in logic offset (#3722)

* [ISSUE #3708] add CorrectLogicOffsetService to periodically correct min logic offset; refactor QueueOffsetAssigner.

* Mock getDiskSpaceWarningLevelRatio and getDiskSpaceCleanForciblyRatio to get around configuration protection in unit-test.

* Fix check style.
@RongtongJin
RongtongJin merged commit 631405e into apache:5.0.0-alpha Feb 9, 2022
@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.02%) to 52.653% when pulling ea086cd on Erik1288:5.0.0-alpha-wait-until-dsl-unit-test into 0b4adb4 on apache:5.0.0-alpha.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants