Skip to content

[Summer of code] Support async learner in controller mode - #4367

Merged
RongtongJin merged 9 commits into
apache:5.0.0-beta-dledger-controllerfrom
hzh0425:feature/async_learner
May 25, 2022
Merged

RongtongJin merged 9 commits into
apache:5.0.0-beta-dledger-controllerfrom
hzh0425:feature/async_learner

Conversation

@hzh0425

@hzh0425 hzh0425 commented May 24, 2022

Copy link
Copy Markdown
Member

What is the purpose of the change

tracking issue: #4330

Brief changelog

Add new broker role -- Async leanrer in controller mode

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@hzh0425 hzh0425 mentioned this pull request May 24, 2022
12 tasks done
@RongtongJin RongtongJin changed the title [Summer of code] Support async leanrer in controller mode [Summer of code] Support async learner in controller mode May 24, 2022
@coveralls

coveralls commented May 24, 2022 •

Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.01%) to 47.67% when pulling 46ddc3c on hzh0425:feature/async_learner into f5c5f5c on apache:5.0.0-beta-dledger-controller.

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

Merging #4367 (46ddc3c) into 5.0.0-beta-dledger-controller (f5c5f5c) will increase coverage by 0.05%.
The diff coverage is 88.57%.

@@                         Coverage Diff                         @@
##             5.0.0-beta-dledger-controller    #4367      +/-   ##
===================================================================
+ Coverage                            43.47%   43.53%   +0.05%     
- Complexity                            6330     6344      +14     
===================================================================
  Files                                  835      835              
  Lines                                59359    59369      +10     
  Branches                              8092     8094       +2     
===================================================================
+ Hits                                 25807    25845      +38     
+ Misses                               30210    30185      -25     
+ Partials                              3342     3339       -3     
Impacted Files Coverage Δ
...mq/store/ha/autoswitch/AutoSwitchHAConnection.java 73.29% <80.00%> (-0.46%) ⬇️
...ache/rocketmq/store/config/MessageStoreConfig.java 56.27% <100.00%> (+0.34%) ⬆️
...cketmq/store/ha/autoswitch/AutoSwitchHAClient.java 75.65% <100.00%> (+0.09%) ⬆️
...etmq/namesrv/routeinfo/BatchUnRegisterService.java 94.73% <0.00%> (-5.27%) ⬇️
...ache/rocketmq/common/stats/MomentStatsItemSet.java 39.13% <0.00%> (-4.35%) ⬇️
.../org/apache/rocketmq/store/ha/DefaultHAClient.java 58.46% <0.00%> (-0.52%) ⬇️
.../apache/rocketmq/logging/inner/LoggingBuilder.java 64.71% <0.00%> (+0.31%) ⬆️
...he/rocketmq/client/impl/consumer/ProcessQueue.java 61.00% <0.00%> (+0.45%) ⬆️
...rocketmq/broker/processor/PopMessageProcessor.java 39.57% <0.00%> (+0.53%) ⬆️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5c5f5c...46ddc3c. Read the comment docs.

@RongtongJin
RongtongJin merged commit 25ee6eb into apache:5.0.0-beta-dledger-controller May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants