Repository navigation
[Summer of code] Fix allAckSyncStateSet not working - #4401
Merged
RongtongJin merged 1 commit intoJun 2, 2022
Merged
RongtongJin merged 1 commit into
RongtongJin merged 1 commit into
Conversation
Codecov Report
@@ Coverage Diff @@
## 5.0.0-beta-dledger-controller #4401 +/- ##
===================================================================
+ Coverage 43.31% 43.32% +0.01%
- Complexity 6342 6343 +1
===================================================================
Files 839 839
Lines 59640 59640
Branches 8130 8130
===================================================================
+ Hits 25831 25842 +11
+ Misses 30460 30446 -14
- Partials 3349 3352 +3
Continue to review full report at Codecov.
|
1 similar comment
RongtongJin
approved these changes
Jun 2, 2022
RongtongJin
approved these changes
Jun 2, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make sure set the target branch to
developWhat is the purpose of the change
Tracking issue: #4330
Fix allAckSyncStateSet not working
Brief changelog
Replace clientAddress to slaveAddress.
Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice,
it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.[ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyleto make sure basic checks pass. Runmvn clean install -DskipITsto make sure unit-test pass. Runmvn clean test-compile failsafe:integration-testto make sure integration-test pass.