Skip to content

Ensure that new messages cannot be written to messagestore during role change - #4423

Merged
ShannonDing merged 1 commit into
apache:5.0.0-beta-dledger-controllerfrom
RongtongJin:5.0.0-beta-dledger-controller-3
Jun 7, 2022
Merged

ShannonDing merged 1 commit into
apache:5.0.0-beta-dledger-controllerfrom
RongtongJin:5.0.0-beta-dledger-controller-3

Conversation

@RongtongJin

Copy link
Copy Markdown
Contributor

Make sure set the target branch to develop

What is the purpose of the change

Ensure that new messages cannot be written to messagestore during role change

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@RongtongJin

Copy link
Copy Markdown
Contributor Author

@hzh0425 PTAL~

@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.04%) to 47.439% when pulling 8274067 on RongtongJin:5.0.0-beta-dledger-controller-3 into e7bf51f on apache:5.0.0-beta-dledger-controller.

@hzh0425 hzh0425 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ShannonDing ShannonDing left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ShannonDing
ShannonDing merged commit fa8ce65 into apache:5.0.0-beta-dledger-controller Jun 7, 2022
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 12 lines in your changes missing coverage. Please review.
βœ… Project coverage is 43.24%. Comparing base (e7bf51f) to head (8274067).

Files with missing lines Patch % Lines
.../rocketmq/broker/hacontroller/ReplicasManager.java 0.00% 4 Missing ⚠️
...etmq/broker/plugin/AbstractPluginMessageStore.java 0.00% 4 Missing ⚠️
...org/apache/rocketmq/store/DefaultMessageStore.java 0.00% 4 Missing ⚠️
Additional details and impacted files
@@                         Coverage Diff                         @@
##             5.0.0-beta-dledger-controller    #4423      +/-   ##
===================================================================
- Coverage                            43.28%   43.24%   -0.04%     
- Complexity                            6346     6348       +2     
===================================================================
  Files                                  840      840              
  Lines                                59707    59719      +12     
  Branches                              8138     8138              
===================================================================
- Hits                                 25843    25826      -17     
- Misses                               30514    30544      +30     
+ Partials                              3350     3349       -1     

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

πŸš€ New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants