Skip to content

[Summer of code] Let controller become role state after append initial logs - #4442

Merged
RongtongJin merged 2 commits into
apache:5.0.0-beta-dledger-controllerfrom
hzh0425:feature/delay-controller-become-leader
Jun 10, 2022
Merged

RongtongJin merged 2 commits into
apache:5.0.0-beta-dledger-controllerfrom
hzh0425:feature/delay-controller-become-leader

Conversation

@hzh0425

@hzh0425 hzh0425 commented Jun 10, 2022

Copy link
Copy Markdown
Member

Make sure set the target branch to develop

What is the purpose of the change

tracking issue: #4330

Brief changelog

Let controller become role state after append initial logs

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@hzh0425

hzh0425 commented Jun 10, 2022

Copy link
Copy Markdown
Member Author

@RongtongJin PTLA

@codecov-commenter

codecov-commenter commented Jun 10, 2022 •

Copy link
Copy Markdown

Codecov Report

Merging #4442 (b4e222d) into 5.0.0-beta-dledger-controller (81dc938) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@                         Coverage Diff                         @@
##             5.0.0-beta-dledger-controller    #4442      +/-   ##
===================================================================
+ Coverage                            43.17%   43.21%   +0.03%     
- Complexity                            6343     6349       +6     
===================================================================
  Files                                  841      841              
  Lines                                59824    59824              
  Branches                              8152     8152              
===================================================================
+ Hits                                 25830    25852      +22     
+ Misses                               30643    30627      -16     
+ Partials                              3351     3345       -6     
Impacted Files Coverage Ξ”
...he/rocketmq/controller/impl/DLedgerController.java 69.94% <100.00%> (ΓΈ)
...controller/impl/DLedgerControllerStateMachine.java 85.00% <100.00%> (ΓΈ)
...ache/rocketmq/common/stats/MomentStatsItemSet.java 39.13% <0.00%> (-4.35%) ⬇️
...mq/broker/topic/TopicQueueMappingCleanService.java 12.43% <0.00%> (-3.63%) ⬇️
...a/org/apache/rocketmq/store/StoreStatsService.java 49.72% <0.00%> (-0.56%) ⬇️
...org/apache/rocketmq/store/DefaultMessageStore.java 53.88% <0.00%> (ΓΈ)
...cketmq/broker/processor/PopBufferMergeService.java 40.71% <0.00%> (+0.23%) ⬆️
...mq/client/impl/producer/DefaultMQProducerImpl.java 44.91% <0.00%> (+0.24%) ⬆️
...che/rocketmq/acl/plain/PlainPermissionManager.java 75.70% <0.00%> (+0.51%) ⬆️
...rocketmq/broker/processor/PopMessageProcessor.java 39.57% <0.00%> (+0.53%) ⬆️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data
Powered by Codecov. Last update 81dc938...b4e222d. Read the comment docs.

@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.02%) to 47.352% when pulling b4e222d on hzh0425:feature/delay-controller-become-leader into 81dc938 on apache:5.0.0-beta-dledger-controller.

@coveralls

coveralls commented Jun 10, 2022 •

Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.002%) to 47.366% when pulling b4e222d on hzh0425:feature/delay-controller-become-leader into 81dc938 on apache:5.0.0-beta-dledger-controller.

@RongtongJin
RongtongJin merged commit 6645d0a into apache:5.0.0-beta-dledger-controller Jun 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants