Skip to content

Polish the logic of change to master - #4464

Merged
odbozhou merged 1 commit into
apache:5.0.0-beta-dledger-controllerfrom
RongtongJin:5.0.0-beta-dledger-controller-5
Jun 15, 2022
Merged

odbozhou merged 1 commit into
apache:5.0.0-beta-dledger-controllerfrom
RongtongJin:5.0.0-beta-dledger-controller-5

Conversation

@RongtongJin

Copy link
Copy Markdown
Contributor

Make sure set the target branch to develop

What is the purpose of the change

Polish the logic of change to master

broker和controller网络分区恢复时,有可能新选的master仍然时以前的,则changeToMaster时可以避免一些操作

Brief changelog

Polish the logic of change to master

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@hzh0425 hzh0425 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter

codecov-commenter commented Jun 15, 2022 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 43.28%. Comparing base (d9273e7) to head (878fde6).

Files with missing lines Patch % Lines
.../rocketmq/broker/hacontroller/ReplicasManager.java 0.00% 9 Missing ⚠️
Additional details and impacted files
@@                         Coverage Diff                         @@
##             5.0.0-beta-dledger-controller    #4464      +/-   ##
===================================================================
+ Coverage                            43.22%   43.28%   +0.06%     
- Complexity                            6358     6371      +13     
===================================================================
  Files                                  841      841              
  Lines                                59860    59862       +2     
  Branches                              8159     8160       +1     
===================================================================
+ Hits                                 25873    25912      +39     
+ Misses                               30632    30599      -33     
+ Partials                              3355     3351       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.02%) to 47.474% when pulling 878fde6 on RongtongJin:5.0.0-beta-dledger-controller-5 into d9273e7 on apache:5.0.0-beta-dledger-controller.

@odbozhou
odbozhou merged commit fd804d9 into apache:5.0.0-beta-dledger-controller Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants