Skip to content

Add deploy and upgrade guide document for controller mode - #4476

Merged
duhenglucky merged 2 commits into
apache:5.0.0-beta-dledger-controllerfrom
RongtongJin:5.0.0-beta-dledger-controller-7
Jun 18, 2022
Merged

duhenglucky merged 2 commits into
apache:5.0.0-beta-dledger-controllerfrom
RongtongJin:5.0.0-beta-dledger-controller-7

Conversation

@RongtongJin

Copy link
Copy Markdown
Contributor

Make sure set the target branch to develop

What is the purpose of the change

Add deploy and upgrade guide document for controller mode

Brief changelog

  1. Add deploy and upgrade guide document for controller mode
  2. Rename enableStartupController to enableControllerInNamesrv

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@RongtongJin

Copy link
Copy Markdown
Contributor Author

@hzh0425 PTAL~

@hzh0425 hzh0425 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.05%) to 47.485% when pulling aca9e84 on RongtongJin:5.0.0-beta-dledger-controller-7 into 9c842e9 on apache:5.0.0-beta-dledger-controller.

@duhenglucky
duhenglucky merged commit a8549e2 into apache:5.0.0-beta-dledger-controller Jun 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants