Skip to content

[ISSUE #4515] Remove implement - #4516

Merged
HScarb merged 2 commits into
apache:developfrom
Oliverwqcwrw:develop-remove-implement-12
Jul 4, 2022
Merged

HScarb merged 2 commits into
apache:developfrom
Oliverwqcwrw:develop-remove-implement-12

Conversation

@Oliverwqcwrw

Copy link
Copy Markdown
Member

Make sure set the target branch to develop

What is the purpose of the change

Close #4515

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@codecov-commenter

codecov-commenter commented Jun 26, 2022 •

Copy link
Copy Markdown

Codecov Report

Merging #4516 (946ffea) into develop (d5b4d84) will decrease coverage by 0.06%.
The diff coverage is 0.00%.

@@              Coverage Diff              @@
##             develop    #4516      +/-   ##
=============================================
- Coverage      48.10%   48.03%   -0.07%     
+ Complexity      5121     5105      -16     
=============================================
  Files            649      649              
  Lines          43026    43026              
  Branches        5626     5626              
=============================================
- Hits           20699    20669      -30     
- Misses         19820    19845      +25     
- Partials        2507     2512       +5     
Impacted Files Coverage Ξ”
...ocketmq/broker/processor/AdminBrokerProcessor.java 35.46% <ΓΈ> (ΓΈ)
...cketmq/broker/processor/ClientManageProcessor.java 29.03% <ΓΈ> (ΓΈ)
...etmq/broker/processor/ConsumerManageProcessor.java 5.88% <ΓΈ> (ΓΈ)
...etmq/broker/processor/EndTransactionProcessor.java 51.40% <ΓΈ> (ΓΈ)
...etmq/broker/processor/ForwardRequestProcessor.java 0.00% <ΓΈ> (ΓΈ)
...ocketmq/broker/processor/PullMessageProcessor.java 41.28% <0.00%> (ΓΈ)
...cketmq/broker/processor/QueryMessageProcessor.java 5.71% <0.00%> (ΓΈ)
...cketmq/broker/processor/ReplyMessageProcessor.java 55.11% <0.00%> (ΓΈ)
...ocketmq/broker/processor/SendMessageProcessor.java 40.05% <ΓΈ> (ΓΈ)
...ketmq/common/protocol/body/ConsumerConnection.java 95.83% <0.00%> (-4.17%) ⬇️
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data
Powered by Codecov. Last update d5b4d84...946ffea. Read the comment docs.

@coveralls

coveralls commented Jun 26, 2022 •

Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.09%) to 51.871% when pulling 946ffea on Oliverwqcwrw:develop-remove-implement-12 into d5b4d84 on apache:develop.

@tsunghanjacktsai tsunghanjacktsai left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Oliverwqcwrw ,

Appreciate your contribution to our community. This is definitely a detailed change. Great job!

Regarding your work, I've also found that there are some similar usages which are redundant in these processors. Would you mind helping us correct those mistakes?

@Oliverwqcwrw

Copy link
Copy Markdown
Member Author

Hi @Oliverwqcwrw ,

Appreciate your contribution to our community. This is definitely a detailed change. Great job!

Regarding your work, I've also found that there are some similar usages which are redundant in these processors. Would you mind helping us correct those mistakes?

Ok,I will solve it

@HScarb
HScarb merged commit ac89db8 into apache:develop Jul 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Polish] The class implement is redundant

9 participants