Skip to content

[ISSUE #4445] Update doc - #4548

Merged
duhenglucky merged 1 commit into
apache:developfrom
Oliverwqcwrw:develop-remove-useless-17
Jul 6, 2022
Merged

duhenglucky merged 1 commit into
apache:developfrom
Oliverwqcwrw:develop-remove-useless-17

Conversation

@Oliverwqcwrw

Copy link
Copy Markdown
Member

Make sure set the target branch to develop

What is the purpose of the change

Close #4445

ps: I do not find this issue in en doc

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@codecov-commenter

codecov-commenter commented Jul 2, 2022 •

Copy link
Copy Markdown

Codecov Report

Merging #4548 (7914996) into develop (493e52b) will increase coverage by 0.05%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             develop    #4548      +/-   ##
=============================================
+ Coverage      48.17%   48.22%   +0.05%     
- Complexity      5129     5137       +8     
=============================================
  Files            649      649              
  Lines          43045    43045              
  Branches        5630     5630              
=============================================
+ Hits           20737    20759      +22     
+ Misses         19801    19780      -21     
+ Partials        2507     2506       -1     
Impacted Files Coverage Ξ”
...in/java/org/apache/rocketmq/test/util/MQAdmin.java 38.88% <0.00%> (-5.56%) ⬇️
...ava/org/apache/rocketmq/test/util/VerifyUtils.java 46.26% <0.00%> (-2.99%) ⬇️
...ava/org/apache/rocketmq/filter/util/BitsArray.java 59.82% <0.00%> (-2.57%) ⬇️
...a/org/apache/rocketmq/filter/util/BloomFilter.java 60.43% <0.00%> (-2.20%) ⬇️
...mq/client/impl/consumer/RebalanceLitePullImpl.java 72.05% <0.00%> (-1.48%) ⬇️
...e/rocketmq/client/impl/consumer/RebalanceImpl.java 43.75% <0.00%> (-0.79%) ⬇️
...a/org/apache/rocketmq/store/StoreStatsService.java 37.81% <0.00%> (-0.57%) ⬇️
...he/rocketmq/client/impl/consumer/ProcessQueue.java 61.92% <0.00%> (-0.46%) ⬇️
.../apache/rocketmq/logging/inner/LoggingBuilder.java 64.39% <0.00%> (-0.32%) ⬇️
...ent/impl/consumer/DefaultLitePullConsumerImpl.java 71.52% <0.00%> (+0.16%) ⬆️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data
Powered by Codecov. Last update 493e52b...7914996. Read the comment docs.

@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.1%) to 52.083% when pulling 7914996 on Oliverwqcwrw:develop-remove-useless-17 into 493e52b on apache:develop.

1 similar comment
@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.1%) to 52.083% when pulling 7914996 on Oliverwqcwrw:develop-remove-useless-17 into 493e52b on apache:develop.

@tsunghanjacktsai tsunghanjacktsai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Oliverwqcwrw ,

Nice catch. We're now planning to restructure and rewrite our documents (as you could see there are many errors in docs and the content is a bit messy), where you can find the work in https://github.com/apache/rocketmq-site/tree/new-official-website/docs. Would you mind joining us and giving us a hand?

@Oliverwqcwrw

Copy link
Copy Markdown
Member Author

Hi @Oliverwqcwrw ,

Nice catch. We're now planning to restructure and rewrite our documents (as you could see there are many errors in docs and the content is a bit messy), where you can find the work in https://github.com/apache/rocketmq-site/tree/new-official-website/docs. Would you mind joining us and giving us a hand?

I'd love to join. How should I contribute ?

@duhenglucky
duhenglucky merged commit 418a5b2 into apache:develop Jul 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Confusion about CN documents(design)

7 participants