Skip to content

Fix bug that return IN_SYNC_REPLICAS_NOT_ENOUGH when enableSlaveActingMaster is false - #4554

Merged
ShannonDing merged 2 commits into
apache:5.0.0-betafrom
RongtongJin:fix-bug-in-5.0.0-beta
Jul 5, 2022
Merged

ShannonDing merged 2 commits into
apache:5.0.0-betafrom
RongtongJin:fix-bug-in-5.0.0-beta

Conversation

@RongtongJin

@RongtongJin RongtongJin commented Jul 4, 2022 •

Copy link
Copy Markdown
Contributor

…alse

Make sure set the target branch to develop

What is the purpose of the change

Fix bug that return IN_SYNC_REPLICAS_NOT_ENOUGH when enableSlaveActingMaster is false

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.05%) to 47.187% when pulling 5c78bea on RongtongJin:fix-bug-in-5.0.0-beta into 52d1c8c on apache:5.0.0-beta.

@ShannonDing ShannonDing left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ShannonDing ShannonDing modified the milestones: 5.0.0-beta, 4.9.4 Jul 5, 2022
@guyinyou

guyinyou commented Jul 5, 2022

Copy link
Copy Markdown
Contributor

Before the change, there will be a situation where the message cannot be sent in the master-slave mode. I hope it can be merged as soon as possible.

@ShannonDing
ShannonDing merged commit ef37465 into apache:5.0.0-beta Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants