Skip to content

Fix examine consume stats for none static topic - #4571

Merged
RongtongJin merged 1 commit into
apache:5.0.0-betafrom
dongeforever:fix_consumer_stats_beta
Jul 8, 2022
Merged

RongtongJin merged 1 commit into
apache:5.0.0-betafrom
dongeforever:fix_consumer_stats_beta

Conversation

@dongeforever

Copy link
Copy Markdown
Member

Make sure set the target branch to develop

What is the purpose of the change

Fix the bug in examineConsumeStats

Brief changelog

For static topics, the physical consumer offsets need to be translated to logic offsets, which is done in DefaultAdminExt.
But it does not handle the case when the topicQueueMapping is null, which means it is a normal topic.

Verifying this change

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@dongeforever

Copy link
Copy Markdown
Member Author

@RongtongJin Please help a review.

@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.04%) to 47.227% when pulling 5600910 on dongeforever:fix_consumer_stats_beta into ef37465 on apache:5.0.0-beta.

@RongtongJin

Copy link
Copy Markdown
Contributor

LGTM~

@RongtongJin
RongtongJin merged commit 9a9f445 into apache:5.0.0-beta Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants