Skip to content

[ISSUE #4617] Correct log info - #4618

Merged
panzhi33 merged 1 commit into
apache:developfrom
Oliverwqcwrw:develop-same-addr-27
Jul 17, 2022
Merged

panzhi33 merged 1 commit into
apache:developfrom
Oliverwqcwrw:develop-same-addr-27

Conversation

@Oliverwqcwrw

Copy link
Copy Markdown
Member

Make sure set the target branch to develop

What is the purpose of the change

Close #4617

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@codecov-commenter

codecov-commenter commented Jul 16, 2022 •

Copy link
Copy Markdown

Codecov Report

Merging #4618 (870e8e4) into develop (225bc42) will increase coverage by 0.11%.
The diff coverage is 91.66%.

@@              Coverage Diff              @@
##             develop    #4618      +/-   ##
=============================================
+ Coverage      43.42%   43.53%   +0.11%     
- Complexity      6213     6225      +12     
=============================================
  Files            817      817              
  Lines          57654    57654              
  Branches        7873     7873              
=============================================
+ Hits           25037    25102      +65     
+ Misses         29384    29314      -70     
- Partials        3233     3238       +5     
Impacted Files Coverage Ξ”
...apache/rocketmq/broker/slave/SlaveSynchronize.java 4.67% <0.00%> (ΓΈ)
...ent/impl/consumer/DefaultLitePullConsumerImpl.java 68.80% <100.00%> (+0.50%) ⬆️
...ketmq/common/protocol/body/ConsumerConnection.java 95.83% <0.00%> (-4.17%) ⬇️
...he/rocketmq/client/trace/AsyncTraceDispatcher.java 81.42% <0.00%> (-1.43%) ⬇️
...mq/client/impl/consumer/RebalanceLitePullImpl.java 69.86% <0.00%> (-1.37%) ⬇️
...client/consumer/store/RemoteBrokerOffsetStore.java 67.56% <0.00%> (-0.91%) ⬇️
.../org/apache/rocketmq/store/ha/DefaultHAClient.java 61.02% <0.00%> (-0.52%) ⬇️
...he/rocketmq/client/impl/consumer/ProcessQueue.java 61.92% <0.00%> (-0.46%) ⬇️
...cketmq/broker/processor/PopBufferMergeService.java 40.71% <0.00%> (+0.23%) ⬆️
.../apache/rocketmq/logging/inner/LoggingBuilder.java 63.76% <0.00%> (+0.31%) ⬆️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data
Powered by Codecov. Last update 00da3e7...870e8e4. Read the comment docs.

@coveralls

coveralls commented Jul 16, 2022 •

Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.002%) to 47.593% when pulling 870e8e4 on Oliverwqcwrw:develop-same-addr-27 into 00da3e7 on apache:develop.

@panzhi33
panzhi33 merged commit d9cec7f into apache:develop Jul 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The old master address printed is the same as the new master address

7 participants