Skip to content
This repository was archived by the owner on Mar 10, 2026. It is now read-only.
This repository was archived by the owner on Mar 10, 2026. It is now read-only.

Web interface does not show current printer option values #3244

Closed

Description

@michaelrsweet

Version: 1.4rc1
CUPS.org User: twaugh.redhat

An error in the templates for showing printer option values means that none of them is SELECTED as the default.

Original bug report:
https://bugzilla.redhat.com/show_bug.cgi?id=506794

Activity

  1. michaelrsweet commented on Jul 1, 2009

    @michaelrsweet
    ContributorAuthor

    CUPS.org User: mike

    P3; patch looks good, thanks!

  2. michaelrsweet commented on Jul 1, 2009

    @michaelrsweet
    ContributorAuthor

    CUPS.org User: mike

    Fixed in Subversion repository.

  3. michaelrsweet commented on Jul 1, 2009

    @michaelrsweet
    ContributorAuthor

    "cups-str3244.patch":

    From 2e2a7f06a4855923a1b3a999e191d032e33f156a Mon Sep 17 00:00:00 2001
    From: Tim Waugh twaugh@redhat.com
    Date: Wed, 1 Jul 2009 14:01:32 +0100
    Subject: [PATCH] Fixed printer option templates to check against defvalue correctly (STR 3244).

    The choices are in a '[]' loop so we need to specify that we want to

    compare against the first element of defvalue, not the nth.

    templates/de/option-boolean.tmpl | 2 +-
    templates/de/option-pickmany.tmpl | 2 +-
    templates/de/option-pickone.tmpl | 2 +-
    templates/es/option-boolean.tmpl | 2 +-
    templates/es/option-pickmany.tmpl | 2 +-
    templates/es/option-pickone.tmpl | 2 +-
    templates/ja/option-boolean.tmpl | 2 +-
    templates/ja/option-pickmany.tmpl | 2 +-
    templates/ja/option-pickone.tmpl | 2 +-
    templates/option-boolean.tmpl | 2 +-
    templates/option-pickmany.tmpl | 2 +-
    templates/option-pickone.tmpl | 2 +-
    templates/pl/option-boolean.tmpl | 2 +-
    templates/pl/option-pickmany.tmpl | 2 +-
    templates/pl/option-pickone.tmpl | 2 +-
    templates/ru/option-boolean.tmpl | 2 +-
    templates/ru/option-pickmany.tmpl | 2 +-
    templates/ru/option-pickone.tmpl | 2 +-
    18 files changed, 18 insertions(+), 18 deletions(-)

    diff --git a/templates/de/option-boolean.tmpl b/templates/de/option-boolean.tmpl
    index 2d0dd55..1b352bb 100644
    --- a/templates/de/option-boolean.tmpl
    +++ b/templates/de/option-boolean.tmpl
    @@ -1,6 +1,6 @@

    {keytext}: -{[choices]{text}} +{[choices]{text}} diff --git a/templates/de/option-pickmany.tmpl b/templates/de/option-pickmany.tmpl index 067075a..0da75e5 100644 --- a/templates/de/option-pickmany.tmpl +++ b/templates/de/option-pickmany.tmpl @@ -1,6 +1,6 @@ {keytext}: -{[choices]{text}} +{[choices]{text}} diff --git a/templates/de/option-pickone.tmpl b/templates/de/option-pickone.tmpl index e467d5f..c88fe05 100644 --- a/templates/de/option-pickone.tmpl +++ b/templates/de/option-pickone.tmpl @@ -1,7 +1,7 @@ {keytext}: -{[choices]{text}} +{[choices]{text}} {iscustom=1?{[params] diff --git a/templates/es/option-boolean.tmpl b/templates/es/option-boolean.tmpl index 2d0dd55..1b352bb 100755 --- a/templates/es/option-boolean.tmpl +++ b/templates/es/option-boolean.tmpl @@ -1,6 +1,6 @@ diff --git a/templates/es/option-pickmany.tmpl b/templates/es/option-pickmany.tmpl index 067075a..0da75e5 100755 --- a/templates/es/option-pickmany.tmpl +++ b/templates/es/option-pickmany.tmpl @@ -1,6 +1,6 @@ diff --git a/templates/es/option-pickone.tmpl b/templates/es/option-pickone.tmpl index 618ee9d..8690af0 100755 --- a/templates/es/option-pickone.tmpl +++ b/templates/es/option-pickone.tmpl @@ -1,7 +1,7 @@
    {paramtext}:
    {keytext}: -{[choices]{text}} +{[choices]{text}}
    {keytext}: -{[choices]{text}} +{[choices]{text}}
    {keytext}: -{[choices]{text}} +{[choices]{text}} {iscustom=1?{[params] diff --git a/templates/ja/option-boolean.tmpl b/templates/ja/option-boolean.tmpl index 2d0dd55..1b352bb 100644 --- a/templates/ja/option-boolean.tmpl +++ b/templates/ja/option-boolean.tmpl @@ -1,6 +1,6 @@ diff --git a/templates/ja/option-pickmany.tmpl b/templates/ja/option-pickmany.tmpl index 067075a..0da75e5 100644 --- a/templates/ja/option-pickmany.tmpl +++ b/templates/ja/option-pickmany.tmpl @@ -1,6 +1,6 @@ diff --git a/templates/ja/option-pickone.tmpl b/templates/ja/option-pickone.tmpl index 8b0a60d..e927e7c 100644 --- a/templates/ja/option-pickone.tmpl +++ b/templates/ja/option-pickone.tmpl @@ -1,7 +1,7 @@
    {paramtext}:
    {keytext}: -{[choices]{text}} +{[choices]{text}}
    {keytext}: -{[choices]{text}} +{[choices]{text}}
    {keytext}: -{[choices]{text}} +{[choices]{text}} {iscustom=1?{[params] diff --git a/templates/option-boolean.tmpl b/templates/option-boolean.tmpl index 2d0dd55..1b352bb 100644 --- a/templates/option-boolean.tmpl +++ b/templates/option-boolean.tmpl @@ -1,6 +1,6 @@ diff --git a/templates/option-pickmany.tmpl b/templates/option-pickmany.tmpl index 067075a..0da75e5 100644 --- a/templates/option-pickmany.tmpl +++ b/templates/option-pickmany.tmpl @@ -1,6 +1,6 @@ diff --git a/templates/option-pickone.tmpl b/templates/option-pickone.tmpl index 05b83ee..5030c46 100644 --- a/templates/option-pickone.tmpl +++ b/templates/option-pickone.tmpl @@ -1,7 +1,7 @@
    {paramtext}:
    {keytext}: -{[choices]{text}} +{[choices]{text}}
    {keytext}: -{[choices]{text}} +{[choices]{text}}
    {keytext}: -{[choices]{text}} +{[choices]{text}} {iscustom=1?{[params] diff --git a/templates/pl/option-boolean.tmpl b/templates/pl/option-boolean.tmpl index 2d0dd55..1b352bb 100644 --- a/templates/pl/option-boolean.tmpl +++ b/templates/pl/option-boolean.tmpl @@ -1,6 +1,6 @@ diff --git a/templates/pl/option-pickmany.tmpl b/templates/pl/option-pickmany.tmpl index 067075a..0da75e5 100644 --- a/templates/pl/option-pickmany.tmpl +++ b/templates/pl/option-pickmany.tmpl @@ -1,6 +1,6 @@ diff --git a/templates/pl/option-pickone.tmpl b/templates/pl/option-pickone.tmpl index 9310072..db40015 100644 --- a/templates/pl/option-pickone.tmpl +++ b/templates/pl/option-pickone.tmpl @@ -1,7 +1,7 @@
    {paramtext}:
    {keytext}: -{[choices]{text}} +{[choices]{text}}
    {keytext}: -{[choices]{text}} +{[choices]{text}}
    {keytext}: -{[choices]{text}} +{[choices]{text}} {iscustom=1?{[params] diff --git a/templates/ru/option-boolean.tmpl b/templates/ru/option-boolean.tmpl index 2d0dd55..1b352bb 100644 --- a/templates/ru/option-boolean.tmpl +++ b/templates/ru/option-boolean.tmpl @@ -1,6 +1,6 @@ diff --git a/templates/ru/option-pickmany.tmpl b/templates/ru/option-pickmany.tmpl index 067075a..0da75e5 100644 --- a/templates/ru/option-pickmany.tmpl +++ b/templates/ru/option-pickmany.tmpl @@ -1,6 +1,6 @@ diff --git a/templates/ru/option-pickone.tmpl b/templates/ru/option-pickone.tmpl index b511ec9..f2dbb5e 100644 --- a/templates/ru/option-pickone.tmpl +++ b/templates/ru/option-pickone.tmpl @@ -1,7 +1,7 @@
    {paramtext}:
    {keytext}: -{[choices]{text}} +{[choices]{text}}
    {keytext}: -{[choices]{text}} +{[choices]{text}}
    {keytext}: -{[choices]{text}} +{[choices]{text}} {iscustom=1?{[params]

    1.6.2.5

    {paramtext}:
  4. added this to the Stable milestone on Mar 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions