You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Mar 10, 2026. It is now read-only.
drv files can cause duplicate PPD names from CUPS-Get-PPDs #3283
Activity
michaelrsweet commentedon Aug 7, 2009
CUPS.org User: twaugh.redhat
Untested patch attached.
michaelrsweet commentedon Aug 7, 2009
CUPS.org User: mike
We can't use your patch as-is since it is 100% possible and allowed to have multiple PPDs (or even a single PPD) matching a given product string.
Will need to look elsewhere to filter out dupes.
michaelrsweet commentedon Aug 29, 2009
CUPS.org User: mike
The patch for STR #3297 addresses this issue by creating one entry with multiple product values instead.
michaelrsweet commentedon Aug 29, 2009
"0001-Don-t-create-duplicate-entries-from-drv-files.patch":
From 964ec8736dafb6bf096c31841136595cde448a4f Mon Sep 17 00:00:00 2001
From: Tim Waugh twaugh@redhat.com
Date: Fri, 7 Aug 2009 12:45:40 +0100
Subject: [PATCH] Don't create duplicate entries from drv files.
If a drv file contains more than one Product attribute for a PPD,
'lpinfo -m' will contain duplicates in its output.
scheduler/cups-driverd.cxx | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/scheduler/cups-driverd.cxx b/scheduler/cups-driverd.cxx
index a014f1a..f842843 100644
--- a/scheduler/cups-driverd.cxx
+++ b/scheduler/cups-driverd.cxx
@@ -1982,7 +1982,7 @@ load_drv(const char filename, / I - Actual filename */
}
product = (ppdcAttr *)d->attrs->next())
1.6.2.5if (!strcmp(product->name->value, "Product"))
{