Skip to content
This repository was archived by the owner on Mar 10, 2026. It is now read-only.
This repository was archived by the owner on Mar 10, 2026. It is now read-only.

dbus notifier typo #3805

Closed
Closed

Description

@michaelrsweet

Version: 1.4.6
CUPS.org User: twaugh.redhat

The job-state-changed notification does not get sent as a D-Bus message due to an error in notifier/dbus.c (sorry).

Fix attached.

Activity

  1. michaelrsweet commented on Mar 4, 2011

    @michaelrsweet
    ContributorAuthor

    CUPS.org User: mike

    Fixed in Subversion repository.

  2. michaelrsweet commented on Mar 4, 2011

    @michaelrsweet
    ContributorAuthor

    "cups-job-state-changed.patch":

    diff -up cups-1.4.6/notifier/dbus.c.job-state-changed cups-1.4.6/notifier/dbus.c
    --- cups-1.4.6/notifier/dbus.c.job-state-changed 2011-02-25 12:42:11.084127808 +0000
    +++ cups-1.4.6/notifier/dbus.c 2011-02-25 12:42:31.312811947 +0000
    @@ -332,7 +332,7 @@ main(int argc, /* I - Number of comm
    const char word2 = event + 4; / Second word */

       params = PARAMS_JOB;
    
    •  if (!strcmp(word2, "state"))
      
    •  if (!strcmp(word2, "state-changed"))
      
      signame = "JobState";
      else if (!strcmp(word2, "created"))
      signame = "JobCreated";
  3. added this to the Stable milestone on Mar 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions