Skip to content
This repository was archived by the owner on Mar 10, 2026. It is now read-only.
This repository was archived by the owner on Mar 10, 2026. It is now read-only.

IPP backend incorrectly includes document-format in Create-Job request #4086

Closed

Description

@michaelrsweet

Version: 1.5.3
CUPS.org User: mike

Currently the IPP backend is including the document-format attribute in the Create-Job request, which isn't correct. This causes problems for specific printers that support Create-Job and correctly validate the supplied operation attributes.

Activity

  1. michaelrsweet commented on May 18, 2012

    @michaelrsweet
    ContributorAuthor

    CUPS.org User: mike

    Fixed in Subversion repository.

  2. michaelrsweet commented on May 18, 2012

    @michaelrsweet
    ContributorAuthor

    "str4086.patch":

    Index: backend/ipp.c

    --- backend/ipp.c (revision 10471)
    +++ backend/ipp.c (working copy)
    @@ -2322,7 +2322,7 @@
    fprintf(stderr, "DEBUG: job-name="%s"\n", title);
    }

    • if (format)
    • if (format && op != IPP_CREATE_JOB)
      {
      ippAddString(request, IPP_TAG_OPERATION, IPP_TAG_MIMETYPE,
      "document-format", NULL, format);
      @@ -2330,7 +2330,7 @@
      }

    #ifdef HAVE_LIBZ

    • if (compression)
    • if (compression && op != IPP_CREATE_JOB)
      {
      ippAddString(request, IPP_TAG_OPERATION, IPP_TAG_KEYWORD,
      "compression", NULL, compression);
  3. added this to the Stable milestone on Mar 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions