Skip to content
This repository was archived by the owner on Mar 10, 2026. It is now read-only.
This repository was archived by the owner on Mar 10, 2026. It is now read-only.

Buffer overread (but appears harmless) #971

Closed

Description

@michaelrsweet

Version: 1.1.22rc1
CUPS.org User: twaugh.redhat

At cups/usersys.c:451 there is the line:

while (isspace(*bufptr & 255) && bufptr >= buf)
*bufptr-- = '\0';

This overreads by one.

Activity

  1. michaelrsweet commented on Oct 20, 2004

    @michaelrsweet
    ContributorAuthor

    CUPS.org User: mike

    Agree, should be harmless but have applied it to CVS for 1.1.22 anyways... :)

  2. michaelrsweet commented on Oct 20, 2004

    @michaelrsweet
    ContributorAuthor

    CUPS.org User: mike

    Fixed in CVS - the anonymous CVS repository will be updated at midnight EST.

  3. michaelrsweet commented on Oct 20, 2004

    @michaelrsweet
    ContributorAuthor

    "cups-overread.patch":

    --- cups-1.1.21rc2/cups/usersys.c.overread 2004-06-29 04:44:52.000000000 +0100
    +++ cups-1.1.21rc2/cups/usersys.c 2004-08-24 13:08:50.083545963 +0100
    @@ -448,7 +448,7 @@
    if (bufptr < buf)
    return (NULL);

    • while (isspace(*bufptr & 255) && bufptr >= buf)
    • while (bufptr >= buf && isspace(*bufptr & 255))
      *bufptr-- = '\0';

    return (buf);

  4. added this to the Stable milestone on Mar 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions