Skip to content
This repository was archived by the owner on Mar 10, 2026. It is now read-only.

configure: improve interpreter detection - #5122

Closed
rohieb wants to merge 3 commits into
apple:masterfrom
rohieb:configure-improve-interpreter-detection
Closed

rohieb wants to merge 3 commits into
apple:masterfrom
rohieb:configure-improve-interpreter-detection

Conversation

@rohieb

@rohieb rohieb commented Sep 25, 2017

Copy link
Copy Markdown
Contributor

Currently, when configure is called with --with-java or --with-java=, auto-detection is performed. When called with --without-java, HAVE_JAVA is still being defined. This is unfortunate when cross-compiling for embedded systems, we would end up with Java on the host being auto-detected (which is not what we have on the target), or with a wrong HAVE_JAVA define.

This implements a way to explicitely disable scripting support for all supported languages with ``without-java` (or the respective options for Perl, PHP and Python)

While we're at it, make the detection a bit more verbose, and do some cleanup.

After the respective AC_DEFINE_UNQUOTED(CUPS_PHP) call, assigning
anything to CUPS_PHP is a no-op. Remove it so the surrounding test looks
like the other tests in the file.

Signed-off-by: Roland Hieber <r.hieber@pengutronix.de>
Currently, when configure is called with --with-java or --with-java=,
auto-detection is performed. When called with --without-java, HAVE_JAVA
is still being defined. This is unfortunate when cross-compiling for
embedded systems, we would end up with Java on the host being
auto-detected (which is not what we have on the target), or with a wrong
HAVE_JAVA define. We need a way to explicitely disable scripting support
for all supported languages.

Signed-off-by: Roland Hieber <r.hieber@pengutronix.de>
Signed-off-by: Roland Hieber <r.hieber@pengutronix.de>
@michaelrsweet

Copy link
Copy Markdown
Contributor

Ultimately I think I want to eliminate all of the third-party scripting support - only Java "needs" special handing as the others support the #! interpreter mechanism...

@rohieb

rohieb commented Sep 27, 2017

Copy link
Copy Markdown
Contributor Author

Ah ok, yes, that seems reasonable. Feel free to only pick the Java part from this PR.

@michaelrsweet

Copy link
Copy Markdown
Contributor

I pushed a slightly different change:

[master b889560] Fixed the script interpreter detection in the configure script (Issue #5122)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants