Skip to content
This repository was archived by the owner on Mar 10, 2026. It is now read-only.

mailto: Wait for server opening message - #5312

Merged
michaelrsweet merged 1 commit into
apple:masterfrom
hansmi:mailtowait1
May 11, 2018
Merged

michaelrsweet merged 1 commit into
apple:masterfrom
hansmi:mailtowait1

Conversation

@hansmi

@hansmi hansmi commented May 8, 2018

Copy link
Copy Markdown
Contributor

A subset of all mailserver configurations reject SMTP sessions where the
client sends anything before the server sent its opening message. This
is the case with Exim on Ubuntu Artful, for example:

SMTP protocol synchronization error (input sent without waiting for
greeting)

Not waiting for the opening message is a violation of the session
initiation described in RFC5321 (section 3.1). Update the mailto
notifier to wait for a non-error status code from the server before
proceeding to start the mail transaction.

A subset of all mailserver configurations reject SMTP sessions where the
client sends anything before the server sent its opening message. This
is the case with Exim on Ubuntu Artful, for example:

  SMTP protocol synchronization error (input sent without waiting for
  greeting)

Not waiting for the opening message is a violation of the session
initiation described in RFC5321 (section 3.1). Update the mailto
notifier to wait for a non-error status code from the server before
proceeding to start the mail transaction.
@michaelrsweet

Copy link
Copy Markdown
Contributor

OK, so we'll definitely pick this up, but I'm thinking I want a wait timeout in there in case we are talking to a non-conforming SMTP server...

@michaelrsweet

Copy link
Copy Markdown
Contributor

Looking at the code we are not doing timeouts for the other cupsFileGets calls, so we'll go with it... :)

@michaelrsweet
michaelrsweet merged commit 8127ebd into apple:master May 11, 2018
@hansmi
hansmi deleted the mailtowait1 branch June 3, 2018 22:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants