Skip to content
This repository was archived by the owner on Mar 10, 2026. It is now read-only.

Correct typos in rastertolabel - #5350

Merged
michaelrsweet merged 5 commits into
apple:masterfrom
benlees:master
Jul 18, 2018
Merged

michaelrsweet merged 5 commits into
apple:masterfrom
benlees:master

Conversation

@benlees

@benlees benlees commented Jul 8, 2018 •

Copy link
Copy Markdown
Contributor

Whilst testing changes for #5092 (see rastertolabel-mods branch), I noticed a few typos in rastertolabel.

  • Zebra CPCL output appears to specify the PAGE-HEIGHT as header->cupsWidth.
  • Intellitech print density outputs an unsigned integer, where a signed integer is required
  • Related to the Intellitech print density, the values for cupsCompression in sample.drv produce the wrong output.

benlees added 5 commits July 8, 2018 10:15
PAGE-HEIGHT is being set to cupsWidth rather than cupsHeight.
Correct page height for Zebra CPCL output
The print density ranges from -15 to +15.  The output should be a signed integer.
Due to an incorrect rounding assumptions in sample.drv, selecting print density choice 14 produces an output of 13 in the driver and so on.
Missed correcting values below 50 (-14 would produce -15 in the output etc).
@michaelrsweet michaelrsweet self-assigned this Jul 9, 2018
@michaelrsweet
michaelrsweet merged commit 4848b9c into apple:master Jul 18, 2018
michaelrsweet added a commit that referenced this pull request Jul 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants