Repository navigation
Split FoundationEssentials extensions from NIOFoundationCompat - #3567
Conversation
FranzBusch
left a comment
There was a problem hiding this comment.
This looks like a straight forward change to me to enable the FoundationEssentials migration across the ecosystem.
|
@glbrntt / @Lukasa Could I request accelerating this? This is a pretty small and good pull request. I'm being asked (in (https://github.com/apple/swift-profile-recorder/pull/63/changes#r3118271068) |
|
These are false positives, as those are readded through the But we will need an admin (paging @Lukasa) to merge those anyway. |
|
Cool, now only transport services is missing for me: apple/swift-nio-transport-services#251 |
|
@Lukasa Is historicalNIOPosixDependencyRequired about import leaks? If yes then that dependency should be moved back to NIOFoundationCompat since NIOFoundationEssentialsCompat doesn't have any historical dependency on NIOPosix. |
Split FoundationEssentials extensions from NIOFoundationCompat
Motivation:
Resolves #3038
Modifications:
Split NIOFoundationCompat into two and only import FoundationEssentials and NIOFoundationEssentialsCompat where appropriate.
Result:
ByteBuffer/Codable extensions can be used without vendoring the code or linking to Foundation.