Repository navigation
Translate HTTPHeaderValidationTests to Swift testing - #3579
Merged
fabianfett merged 3 commits intoApr 21, 2026
Merged
fabianfett merged 3 commits into
fabianfett merged 3 commits into
Conversation
simonjbeaumont
approved these changes
Apr 21, 2026
simonjbeaumont
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Up to you whether we put the explicit failure message back in for those few asserts that had them β they dropped off when moving to the Swift Testing equivalents.
|
|
||
| XCTAssertThrowsError( | ||
| try channel.writeOutbound(HTTPServerResponsePart.head(badResponse)), | ||
| "Incorrectly tolerated character in header field value: \(String(decoding: [byte], as: UTF8.self))" |
Contributor
There was a problem hiding this comment.
We lost the explicit message here when this expectation is not met, and in a few other places.
fabianfett
force-pushed
the
ff-translate-HTTPRequestValidationTests-to-swift-testing
branch
from
April 21, 2026 14:23
1cc9072 to
2a46892
Compare
fabianfett
deleted the
ff-translate-HTTPRequestValidationTests-to-swift-testing
branch
April 21, 2026 14:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Translate
HTTPHeaderValidationTeststo Swift testingMotivation:
We want to add tests that use parameterized testing to
HTTPHeaderValidationTests. In order to allow this we first need to translate this file to use Swift Testing instead of XCTest.Modifications:
HTTPHeaderValidationTestsfrom XCTest to Swift testing.Result:
We can add parameterized tests to HTTPHeaderValidationTests.