Repository navigation
Deprecate Xcode version inputs in macos_tests.yml - #3590
Merged
Merged
Conversation
Motivation * The `swift_*` inputs request Xcodes by Swift version with symlinks on the runners owning the mapping. This more directly expresses the library support window. * All callers should migrate to `swift_6_1/6_2/6_3_enabled` instead of specifying Xcode versions directly. Modifications * Default `xcode_16_3/16_4/26_0/26_1/26_2_enabled` to `false` and mark their descriptions as deprecated. * Default `swift_6_1/6_2/6_3_enabled` to `true`. Result * Repos still passing `xcode_*_enabled: true` explicitly continue to work until they migrate.
Motivation * Xcode version inputs in `macos_tests.yml` now default to `false` and Swift version inputs default to `true`. * NIO's `main.yml` and `pull_request.yml` were explicitly setting these values, which now just restate the defaults. Modifications * Remove the redundant `xcode_*_enabled: false` and `swift_*_enabled: true` lines from both workflow files. Result * Less noise in the workflow files; NIO relies on the shared workflow defaults like other repos will.
FranzBusch
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
swift_*inputs request Xcodes by Swift version with symlinks onthe runners owning the mapping. This more directly expresses the
library support window.
swift_6_1/6_2/6_3_enabledinstead ofspecifying Xcode versions directly.
Modifications
xcode_16_3/16_4/26_0/26_1/26_2_enabledtofalseand marktheir descriptions as deprecated.
swift_6_1/6_2/6_3_enabledtotrue.Result
xcode_*_enabled: trueexplicitly continue towork until they migrate.