Repository navigation
Remove defunct Xcode version inputs from macos_tests.yml - #3591
Merged
Merged
Conversation
Motivation * `xcode_15_4`, `xcode_16_0`, `xcode_16_1`, `xcode_16_2`, and `xcode_26_beta` inputs were already deprecated and defaulted to `false`. No callers should still be passing them. Modifications * Remove the input declarations, shell variable assignments, matrix construction blocks, and environment variable mappings for the removed versions. Result * Less dead code in `macos_tests.yml`.
Motivation * Xcode 16.3, 16.4, 26.0, and 26.1 will soon be uninstalled from the runners. The inputs are kept so downstream callers don't break, but they no longer produce any matrix entries. Modifications * Update descriptions to communicate the inputs have no effect. * Remove the shell variable assignments, matrix construction blocks, and environment variable mappings for these versions. Result * Callers passing these inputs get no error but also no job β a graceful no-op while they migrate to `swift_*` inputs.
AzeemJiva
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
and defaulted to
falsewith no callers enabling them β redundant code.runners. Their inputs are kept so downstream callers don't break, but
they should no longer produce any matrix entries.
Modifications
blocks, and environment variable mappings for 15.4/16.0/16.1/16.2/26
beta entirely.
declarations as no-ops, with descriptions communicating they have no
effect.
Result
xcode_16_3throughxcode_26_1inputs get noerror but also no job β a graceful no-op while they migrate to
swift_*inputs.